On Thu, Apr 3, 2014 at 1:07 AM, Dave Page <[email protected]> wrote: > We don't have a cancel option for Search/Replace. We only have Close - > which is what the X button does, so I think we should save in all cases. > Ok. In that case - the patch looks good to me.
> > > On Wed, Apr 2, 2014 at 11:02 AM, Ashesh Vashi < > [email protected]> wrote: > >> Dave/J.F. >> >> My thinking for this is little different. >> In general, if a user cancels any operation, he/she does not want the >> changes. >> >> So - we should save the settings only on "Find/Replace/ReplaceAll" >> action, along with Close (but - not definitely with Cancel operation/Cross >> button). >> >> >> >> On Thu, Mar 20, 2014 at 9:03 PM, J.F. Oster <[email protected]> wrote: >> >>> Hello, >>> >>> Make "Find & Replace" dialog in SQL Box remember search settings when >>> it is closed (in any way; in fact it's being hidden). >>> >>> Existing instances of dialog, once invoked again, will keep their own >>> settings. >>> New instance of dialog will gain settings of the last dialog which has >>> been closed before it's invocation. >>> >>> >>> >>> >>> By the way, I was puzzled why search dialog's settings are saved >>> >>> sometimes and sometimes are not. Depending on dialog's close method: >>> >>> 1. Pressing ESC or "Close" form button calls OnCancel() which does >>> not >>> >>> save; >>> >>> 2. Pressing title [x] button or Alt-F4 (or similar OS hotkey) calls >>> >>> OnClose() which does save. >>> >>> >>> >>> Shouldn't the behaviour be the same regardless of dialog's close >>> >>> method? Or at least the difference should be noted in documentation. >>> >>> DP>> Yes, it should. Patches welcome :-) >>> >>> JFO> Ok, after the current patch is applied I'll send in another one to >>> JFO> make it save settings in both cases. >>> >>> >>> -- >>> Best regards, >>> J.F. >>> >>> -- >>> Sent via pgadmin-hackers mailing list ([email protected]) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> >> >> -- >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL >> Company<http://www.enterprisedb.com> >> >> >> >> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi> >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
