Thanks J.F. Oster for the patch, and Sanket Mehta for reviewing it. I've committed it in the repository.
-- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Wed, Oct 29, 2014 at 12:52 PM, Sanket Mehta < [email protected]> wrote: > Hi J.F., > > Thank you for the explanation. > I have reviewed the patch. > It resolves both issues mentioned in the explanation. > > > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Tue, Oct 28, 2014 at 10:16 PM, J.F. Oster <[email protected]> wrote: > >> Hello Sanket, >> >> Steps to reveal issues: >> >> 1. Prepare test tables: >> CREATE TABLE tserial2 ( >> a smallserial NOT NULL, >> dat text, >> CONSTRAINT tserial2_pkey PRIMARY KEY (a) >> ); >> >> -- Create these for reference (to compare): >> CREATE TABLE tserial( >> a serial NOT NULL, >> dat text, >> CONSTRAINT tserial_pkey PRIMARY KEY (a) >> ); >> CREATE TABLE tserial8( >> a bigserial NOT NULL, >> dat text, >> CONSTRAINT tserial8_pkey PRIMARY KEY (a) >> ); >> >> 2. Open Edit data window for tserial2. Bug#1: the header for column "a" >> shows >> datatype "smallint" instead of "smallserial". >> >> 3. Insert one row into tserial2. >> >> 4. Select whole new row by pressing on row header and copy it to >> clipboard (Ctrl-C or with context menu on row header). >> >> 5. Move to last row (*) and Paste into it (Ctrl-V or context menu). >> Bug#2: A confirmation dialog should appear ("This table contains >> serial ..."), but it doesn't. >> >> >> Tuesday, October 28, 2014, 1:27:29 PM, you wrote: >> >> >> SM> Can you please explain in which case it will create issue if bug is >> not applied? >> >> >> SM> On Mon, Oct 27, 2014 at 4:14 PM, Dave Page <[email protected]> wrote: >> SM> Ashesh, can you review/commit this please? >> >> SM> On Fri, Oct 24, 2014 at 8:12 PM, J.F. Oster <[email protected]> >> wrote: >> >> Hello! >> >> >> >> This patch adds a few missing lines of code to handle smallserial >> >> columns the same way as serial and bigserial. >> >> >> >> -- >> Best regards, >> J.F. >> >> >
