Hi Sanket, Below are the review comments.
- When we edit any existing cast node then it gives error "*Response object has no attribute strip*". This error is coming because generated SQL is wrong. - Unnecessary debug logs are coming on console. Please remove unnecessary debug logs. - In some of the sql file, 'qtIdent' and 'qtLiteral' is not used. Please check all the SQL files. - "Delete" cast functionality is not working. Error is getting displayed saying *"syntax error at or near "castsource"*. - "Delete cascade" functionality is not working - error is getting displayed saying *"The requested URL not found".* - Do the proper comments, in some of the function like "script_load" , comments are wrong. - Is "configs" really required in __init__.py file ? We have not seen any usage for this. Please remove it if it is not required. - Remove commented code from the source file. Please check all the generated SQL statements . Test the basic functionality of "create", "Edit" and "Delete" node before sending patch file. Do let us know for any comments/issues. Thanks, Neel Patel On Tue, Jan 19, 2016 at 8:06 PM, Sanket Mehta <sanket.me...@enterprisedb.com > wrote: > Hi, > > PFA updated patch for cast module as per check list provided by Neel. > Please do review it and let me know in case of anything is missing. > > > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Mon, Jan 18, 2016 at 7:16 PM, Sanket Mehta < > sanket.me...@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch for cast module. >> Please do review it and let me know in case of any issue. >> >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > >
