Hi
On Fri, Mar 4, 2016 at 6:28 AM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi,
>
> Please find attached patch for numeric and integer control with optionally
> null value support.
>
> Usage:
>
> 1] Integer
>
> id: 'fillfactor', label: '{{ _('Fill factor') }}', deps: ['index'],
> type: 'int', group: '{{ _('Definition') }}', allowNull: true,
>
>
> 2] Numeric
>
> id: 'fillfactor', label: '{{ _('Fill factor') }}', deps: ['index'],
> type: 'numeric', group: '{{ _('Definition') }}', allowNull: true,
>
>
You've used regexps to validate numbers in this patch, however they assume
that the only value number formats are (ignoring a leading -):
1234567 (integer)
1234567.89 (numeric)
However, this is only the standard in some countries - for example, a
French user might write a numeric as:
1 234 567,89
Even in India that might be written as:
12,34,567.89
In Germany:
1.234.567,89
The numeric inputs should be validated based on the client's locale.
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
