Hi All,

Below is the query to fetch Input/Output/Send/Receive/Analyze functions
while creating new external type (create mode) in pgAdmin3,

With latest git pull [File: pgadmin/dlg/dlgType.cpp] [Line: 548],

*Current:*
SELECT proname, nspname
FROM (
SELECT proname, nspname, max(proargtypes[0]) AS arg0, max(proargtypes[1])
AS arg1
FROM pg_proc p
JOIN pg_namespace n ON n.oid=pronamespace
GROUP BY proname, nspname
HAVING count(proname) = 1 ) AS uniquefunc
WHERE arg0 <> 0 AND *arg1 = 0*;


*Modified: *SELECT proname, nspname
FROM (
SELECT proname, nspname, max(proargtypes[0]) AS arg0, max(proargtypes[1])
AS arg1
FROM pg_proc p
JOIN pg_namespace n ON n.oid=pronamespace
GROUP BY proname, nspname
HAVING count(proname) = 1 ) AS uniquefunc
WHERE arg0 <> 0 AND *arg1 IS NULL*;


When I changed where condition to 'arg1 IS NULL' from 'arg1 = 0', All combo
boxes are populated.

Can someone please confirm if it's correct?

Please review attached patch for the same.


Regards,
Murtuza
diff --git a/pgadmin/dlg/dlgType.cpp b/pgadmin/dlg/dlgType.cpp
index d8454c3..59c3f9c 100644
--- a/pgadmin/dlg/dlgType.cpp
+++ b/pgadmin/dlg/dlgType.cpp
@@ -553,7 +553,7 @@ int dlgType::Go(bool modal)
 		          wxT("          JOIN pg_namespace n ON n.oid=pronamespace\n")
 		          wxT("         GROUP BY proname, nspname\n")
 		          wxT("        HAVING count(proname) = 1   ) AS uniquefunc\n")
-		          wxT(" WHERE arg0 <> 0 AND arg1 = 0"));
+		          wxT(" WHERE arg0 <> 0 AND arg1 IS NULL"));
 
 		if (set)
 		{
-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Reply via email to