Very nice! On Tue, Apr 12, 2016 at 1:11 PM, Akshay Joshi <[email protected] > wrote:
> Hi Dave > > As per suggestion, I have changed History tab to be a grid. Attached is > the two screenshot one for Query Tool and other is for the Data Grid where > some of the transaction gets rollback while saving the data due to one of > the error condition. Please review the screenshots and let me know the > comments if any. > > On Fri, Apr 8, 2016 at 9:49 PM, Dave Page <[email protected]> wrote: > >> >> >> On Fri, Apr 8, 2016 at 3:39 PM, Akshay Joshi < >> [email protected]> wrote: >> >>> Hi Dave >>> >>> On Fri, Apr 8, 2016 at 2:32 PM, Dave Page <[email protected]> wrote: >>> >>>> >>>> >>>> On Fri, Apr 8, 2016 at 7:43 AM, Akshay Joshi < >>>> [email protected]> wrote: >>>>> >>>>> >>>>>>>>>> - The Query Tool menu icon should be a glyphicon, to match the >>>>>>>>>> others. >>>>>>>>>> >>>>>>>>> >>>>>>>>> There is no glyphicon available which match the Query Tool >>>>>>>>> icon. I have found one like below which is "database-search" or can >>>>>>>>> you >>>>>>>>> please suggest some other icon. >>>>>>>>> [image: Inline image 1] >>>>>>>>> >>>>>>>> >>>>>>>> That one looks perfect. >>>>>>>> >>>>>>> >>>>> We can't use this icon because it's not come with Bootstrap >>>>> , I have picked this from "http://glyphicons.com/"; and I am not sure >>>>> we can use it as per the Licence. >>>>> >>>> >>>> At the risk of annoying everyone immensely, on reflection I'm thinking >>>> we should use Font Awesome as our default generic icons, and fall back to >>>> Bootstrap's Glyphicons. I really hadn't realised how much larger the FA set >>>> is. >>>> >>>> For this particular issue, could we use FA's stacking? e.g. something >>>> like: https://jsfiddle.net/pa8x6nt3/ >>>> >>>> If not, how about using the execute icon we discussed, e.g. fa-bolt? >>>> >>> >>> I have used fa-bolt. Apart from that I have completed below review >>> comments >>> >> >> OK. >> >> >>> >>> >>> - The View Data menu option should be on the Object menu, which >>> should mirror the Context menu, except options should be disabled when >>> not >>> applicable instead of hidden. *Note*: - With current implementation >>> "Object" menu is re-created dynamically depending on the node clicked, so >>> we will have to re-create the "View Data" menu as well and it require >>> change in the generic code. For the time being "View Data" menu is >>> visible >>> in "Object" menu when appropriate node is selected. >>> - Please merge the functionality of the Refresh and Execute buttons >>> into one button. We shouldn't have two buttons that do essentially the >>> same >>> thing. >>> - In Edit Grid mode, that textbox should be read-only, but should >>> display the SQL used (including any LIMIT/FILTER clauses). Please >>> refer the attached screenshot (Modified-Data-Grid). >>> - Please adjust the height of the Delete icon in the Edit Grid, such >>> that it doesn't force the row height to be higher than it should be. >>> - I think the names of the tabs are far too long. Can we change them >>> to "Query 1", "Query 2" etc, then rename them to the filename if the >>> user saves/loads a file? *Note*: - As discussed I have added one >>> more container to show the title. Please refer the attached screenshots >>> (Modified-Query-Tool) >>> - Query results should have spaces converted to " ", so that >>> proper indenting is maintained (for example, on EXPLAIN queries) >>> - To fix this we have added css style "*white-space: pre-wrap;*", >>> but it changes the backgrid cell size. Please refer the >>> screenshot (Modified-Data-Grid). >>> >>> Hmmm. I'd rather that the heights didn't change (or at least the rows >> were resizeable like in pga3. Can we set the column to hide vertical >> overflow, unless it gets focus or something? >> >> >>> Please review the screenshots and please let me know will it looks >>> good. >>> >> >> Bar the cell size, certainly it's good :-) >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
