Hi Murtuza Below are my review comments
- Please change the title from "AlertifyJS" to "Restore point name" - Please change the string from "Enter the name of the restore point" to "Enter the name of the restore point to add"(pgAdmin3). On Thu, May 12, 2016 at 11:20 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch which will validate user input & throws an error if > empty, ask for input again. > > > Regards, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, May 12, 2016 at 10:57 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> On Thu, May 12, 2016 at 10:47 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> If user provides empty name then we are already throwing an error. >>> Do you still want me to disable button? >>> >> >> Yes - we should most possible of the validation at client, and server too. >> We should leave least validation for the database server, which is not >> possible in pgAdmin 4. >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> <http://www.enterprisedb.com/> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> <http://www.linkedin.com/in/asheshvashi> >> >>> >>> Regards, >>> Murtuza >>> >>> > On 11-May-2016, at 8:45 pm, Dave Page <dp...@pgadmin.org> wrote: >>> > >>> > Committed as is, but please submit a patch to disable the OK button, >>> > until a name has been entered, to avoid accepting an empty name. >>> > >>> > Thanks! >>> > >>> > On Wed, May 11, 2016 at 11:59 AM, Murtuza Zabuawala >>> > <murtuza.zabuaw...@enterprisedb.com> wrote: >>> >> Hi, >>> >> >>> >> PFA updated patch with i18n support added in message. >>> >> >>> >> Regards, >>> >> Murtuza >>> >> >>> >> -- >>> >> Regards, >>> >> Murtuza Zabuawala >>> >> EnterpriseDB: http://www.enterprisedb.com >>> >> The Enterprise PostgreSQL Company >>> >> >>> >> On Wed, May 11, 2016 at 3:50 PM, Murtuza Zabuawala >>> >> <murtuza.zabuaw...@enterprisedb.com> wrote: >>> >>> >>> >>> Hi, >>> >>> >>> >>> PFA updated patch for named restore point and I have also updated >>> reload >>> >>> configuration menu enable/disable condition as mentioned. >>> >>> >>> >>> Regards, >>> >>> Murtuza >>> >>> >>> >>> -- >>> >>> Regards, >>> >>> Murtuza Zabuawala >>> >>> EnterpriseDB: http://www.enterprisedb.com >>> >>> The Enterprise PostgreSQL Company >>> >>> >>> >>> On Wed, May 11, 2016 at 2:03 PM, Ashesh Vashi >>> >>> <ashesh.va...@enterprisedb.com> wrote: >>> >>>> >>> >>>> On Wed, May 11, 2016 at 1:11 PM, Murtuza Zabuawala >>> >>>> <murtuza.zabuaw...@enterprisedb.com> wrote: >>> >>>>> >>> >>>>> Hi All, >>> >>>>> >>> >>>>> >>> >>>>> PFA patch which will add "Adding named restore point" >>> functionality on >>> >>>>> server. >>> >>>> >>> >>>> Create named restore point is action restricted to the superuser >>> only. >>> >>>> Please check that in the menu enable/disable functionality. >>> >>>> >>> >>>> The check also applicable to 'relaod configuration'. >>> >>>>> >>> >>>>> >>> >>>>> -- >>> >>>>> Regards, >>> >>>>> Murtuza Zabuawala >>> >>>>> EnterpriseDB: http://www.enterprisedb.com >>> >>>>> The Enterprise PostgreSQL Company >>> >>>>> >>> >>>>> >>> >>>>> -- >>> >>>>> Sent via pgadmin-hackers mailing list ( >>> pgadmin-hackers@postgresql.org) >>> >>>>> To make changes to your subscription: >>> >>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>>>> >>> >>>> >>> >>> >>> >> >>> >> >>> >> >>> >> -- >>> >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org >>> ) >>> >> To make changes to your subscription: >>> >> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >> >>> > >>> > >>> > >>> > -- >>> > Dave Page >>> > Blog: http://pgsnake.blogspot.com >>> > Twitter: @pgsnake >>> > >>> > EnterpriseDB UK: http://www.enterprisedb.com >>> > The Enterprise PostgreSQL Company >>> >>> >> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
