On Thu, May 12, 2016 at 11:45 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote:
> Hi, > > > -- > *Harshal Dhumal* > *Software Engineer * > > > > EenterpriseDB <http://www.enterprisedb.com> > > On Thu, May 12, 2016 at 4:16 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Thu, May 12, 2016 at 4:14 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Harshal >>> >>> Below are my review comments : >>> >>> - Facing error unexpected identifier 'change_password: >>> function(args)' in js file. >>> - Please correct the spelling of password in the menu item. >>> - Title for alertify dialog showing "Change password for servers" it >>> should be only "Change Password" or "Change Password for <server name>". >>> >>> It should be "Change password for the user on the server - '<server >> name>'". >> > > Fixed in latest patch. Also added user name whose password we are changing. > Thanks - Committed with some GUI changes. > > >> >>> - >>> - Facing error "name 'decrypt' is not defined." >>> - Not able to change the password facing error. >>> >>> >>> On Thu, May 12, 2016 at 1:43 PM, Harshal Dhumal < >>> harshal.dhu...@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> PFA updated patch. >>>> >>>> -- >>>> *Harshal Dhumal* >>>> *Software Engineer * >>>> >>>> >>>> >>>> EenterpriseDB <http://www.enterprisedb.com> >>>> >>>> On Thu, May 12, 2016 at 1:27 PM, Harshal Dhumal < >>>> harshal.dhu...@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> This patch needs a rebase. (as "Named restore point" patch is >>>>> committed.) >>>>> >>>>> -- >>>>> *Harshal Dhumal* >>>>> *Software Engineer * >>>>> >>>>> >>>>> >>>>> EenterpriseDB <http://www.enterprisedb.com> >>>>> >>>>> On Wed, May 11, 2016 at 12:35 PM, Harshal Dhumal < >>>>> harshal.dhu...@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> PFA patch for changing server password. >>>>>> >>>>>> >>>>>> -- >>>>>> *Harshal Dhumal* >>>>>> *Software Engineer * >>>>>> >>>>>> >>>>>> >>>>>> EenterpriseDB <http://www.enterprisedb.com> >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>>> >>> >>> >>> -- >>> *Akshay Joshi* >>> *Principal Software Engineer * >>> >>> >>> >>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >> >> > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
