Fixed all the review comments from Dave. * Moved the Columns, and Constraint to its repective tabs. * Ensure all the labels only have a capital letter on the first word (except for keywords or acronyms). * Resolve the typo in string - 'System table'. * Error messages on fields should not be shown unless the field loses focus and has an error. * "General" section should have a limited subset of information. * Variables grids should not be on the Security tab. * Fixes the field labels that imply a question. * Privileges controls on the Properties lists should be in a "Security" group.
Apart from review comments improved few other areas too: * Used in-place DepsCell functionality for columns in both index, and type node. * Improved the error handling in constraint nodes. * Added create, alert SQL Help for nodes associated with the table node. Branch ------ master Details ------- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af84ba5a4f4db59f672d47f98f684d9d5a2c4160 Author: Murtuza Zabuawala <murtuza.zabuaw...@enterprisedb.com> Modified Files -------------- .../tables/column/templates/column/js/column.js | 67 ++-- .../check_constraint/js/check_constraint.js | 7 +- .../js/exclusion_constraint.js | 10 +- .../templates/foreign_key/js/foreign_key.js | 18 +- .../index_constraint/js/index_constraint.js | 25 +- .../tables/indexes/templates/index/js/index.js | 117 ++++-- .../schemas/tables/templates/table/js/table.js | 413 +++++++++++---------- .../databases/schemas/tables/triggers/__init__.py | 2 +- .../triggers/templates/trigger/js/trigger.js | 114 +++--- .../servers/databases/schemas/types/__init__.py | 3 +- .../schemas/types/templates/type/js/type.js | 99 ++++- .../templates/type/sql/9.1_plus/get_types.sql | 3 +- .../schemas/views/templates/mview/js/mview.js | 40 +- .../templates/file_manager/js/file_manager.js | 75 ++-- .../templates/file_manager/js/utility.js | 3 +- 15 files changed, 589 insertions(+), 407 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
