Hi, Please find updated patch: *Issue*: Code changes are not consistent with the present code in functions/__init__.py, like don't rename variable func_def to func_defintion until it is required. Review comment given by Ashesh personally.
Please review. On Fri, Jun 3, 2016 at 3:31 PM, Surinder Kumar < [email protected]> wrote: > Hi, > > Please find attached patch for: > 1. RM#1293 - SQL pane is not displaying GRANT queries in functions node > 2. RM#1294 - Comments are not visible in sql pane for trigger functions > and functions > > Explanation: > Previously we we using 'get_defintion.sql' template to generate SQL for > SQL pane for functions, procedure & trigger functions node. > but GRANT statements and COMMENTS changes were missing. In order to fix > that, now we have used both 'create.sql' and 'get_definition.sql' templates > to generate full SQL query > for SQL pane. > > Please review. > > On Thu, Jun 2, 2016 at 7:32 PM, Surinder Kumar < > [email protected]> wrote: > >> Please ignore this patch. I will send another patch. >> >> On Thu, Jun 2, 2016 at 7:25 PM, Surinder Kumar < >> [email protected]> wrote: >> >>> Hi, >>> >>> Please find attached patch for RM#1293. >>> Add support to display GRANT privilege query in SQL Pane. >>> >>> Please review. >>> >>> Thanks, >>> Surinder Kumar >>> >> >> >
fix_for_RM#1293_and_RM#1294_v1.patch
Description: Binary data
-- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
