Thanks. I've pushed this with changes to reformat some of the SQL, and ensure the column headers are properly cased.
There is one outstanding bug though - if an object is selected for which the stats query doesn't return any rows (e.g. track_functions = false), then weird things happen - you get an empty error message, or the previous stats might be re-shown. Please fix the patch so that in such cases the pgAdmin 3 behaviour is followed, i.e. the table header is shown, but no rows (bug #1316). Also, please look at #1315 which you're at it :-) Thanks again. On Tue, Jun 7, 2016 at 12:27 PM, Murtuza Zabuawala <[email protected]> wrote: > Hi, > > PFA patch to add Statistics functionality to below nodes, > > Table > Function > Procedure > Trigger Function > Sequence > Index > Column > Primary Key > Unique constraint > Exclusion constraint > > (RM#1299) > > --------------- > > Additionally, attaching two separate patches, > > 1) To update validation of object before using it > (file: statistics.js) > > 2) To fix incorrect condition checking for privileges. > Thanks to Surinder for reporting this issue. > (file: privilege.js) > > > Please review. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list ([email protected]) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
