On Mon, Aug 8, 2016 at 5:52 PM, Dave Page <[email protected]> wrote: > On Mon, Aug 8, 2016 at 1:15 PM, Surinder Kumar > <[email protected]> wrote: > > On Mon, Aug 8, 2016 at 4:43 PM, Dave Page <[email protected]> wrote: > >> > >> Hi Surinder, > >> > >> This looks very promising, but it only covers the query tool at > >> present. We need the shortcuts to apply to all codemirror instances. > >> Do the others work anyway, because we're invoking in a different way, > >> or is more work needed there? > > > > To apply the same shortcuts to other codemirror instances(e.g: > > SqlTabControl) we just need to set a parameter > > extraKeys: pgAdmin.editor_shortcut_keys for every codemirror instance. > > As of now, shortcuts are applicable to query tool & data filter. > > > > Also, we need to define pgAdmin.editor_shortcut_keys variable in > server.js > > instead of sqleditor.js to work it for > > other code mirror instances. > > OK, please update the patch to do that. > > Can you get that to me in the next hour or so? I'd like to include it in > beta 4. > Sure.
> > >> On Fri, Aug 5, 2016 at 6:42 PM, Surinder Kumar > >> <[email protected]> wrote: > >> > Hi > >> > > >> > I found that Code-mirror library itself provides the List of keyboard > >> > shortcuts for Mac OSX and other platform type. > >> > We just need to pass them in extraKeys param while creating > code-mirror > >> > instance. > >> > > >> > Following is the keyboard shortcuts for various operations in text > >> > editor: > >> > > >> > Copy - [Ctrl-C, Cmd-C] > >> > Cut - [Ctrl-X, Cmd-X] > >> > Select All - [Ctrl-A, Cmd-A] > >> > Undo - [Ctrl-Z, Cmd-Z] > >> > Redo - [Ctrl-Y, Cmd-Y] > >> > Delete Line - [Ctrl-D, Cmd-D] > >> > Move left/right(words) - [Alt-Left, Alt-Right] > >> > Move start/end of line - [Cmd-Left, Cmd-Right] // Ctrl-Left/Right are > >> > bound > >> > to System shortcuts. so these keys cannot be used. > >> > > >> > These keyboard shortcuts are consistent in Web/Runtime applications in > >> > all > >> > platform types. > >> > > >> > Issue not fixed: > >> > keyboard shortcut for Paste text doesn't work in Mac Runtime only. It > is > >> > working on Linux runtime & Windows Runtime. > >> > An issue "Key shortcuts doesn't work on Mac OS for QWebView widget" is > >> > also > >> > reported. > >> > > >> > I also found that right click paste is working in Mac Runtime which is > >> > the > >> > feature of code-mirror, So I am looking into its code to figure out > and > >> > I > >> > will send a patch with fix once it gets fixed. > >> > > >> > Please find attached patch and review. > >> > > >> > > >> > Thanks, > >> > Surinder Kumar > >> > > >> > > >> > > >> > -- > >> > Sent via pgadmin-hackers mailing list ([email protected] > ) > >> > To make changes to your subscription: > >> > http://www.postgresql.org/mailpref/pgadmin-hackers > >> > > >> > >> > >> > >> -- > >> Dave Page > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > >> > >> EnterpriseDB UK: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
