Thanks, applied. On Thu, Aug 18, 2016 at 10:21 AM, Murtuza Zabuawala <murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch with auto scrolling & also fixed duplicate > messages issue. > Please review. > > Regards, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Aug 17, 2016 at 7:09 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi >> >> On Tue, Aug 16, 2016 at 3:56 PM, Murtuza Zabuawala >> <murtuza.zabuaw...@enterprisedb.com> wrote: >> > Hi Dave, >> > >> > PFA updated patch. >> >> I just tested this, and found a number of issues: >> >> - For a query like VACUUM FULL ANALYZE VERBOSE, the query runtime is >> not displayed at the end of the messages. It is for SELECT queries >> (note: pgAdmin 3 returns "Query returned successfully with no result >> in 6.6 secs."). >> >> - Messages seem to be duplicated. For example, the output from the >> query above, run on pgAdmin3 is 95KB, whilst from pgAdmin4 it's >> 3.1MB(!). I believe it's because you're not clearing __notices in >> messages(). I'm not entirely clear why that's even needed though - >> can't we just return messages from self.conn.notices and clear that >> directly? >> >> - The messages div should scroll to the end as it's updated, per >> discussion. >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > >
-- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
