1 more point to add: 5. Synonyms should only run for EPAS server
On 26 August 2016 at 16:44, Priyanka Shendge < priyanka.shen...@enterprisedb.com> wrote: > Hi Murtuza, > > Please find my review comments below: > > 1. Please attach test_advanced_config.json.in file to read the config data > 2. While reading data from config file "owner" field is missing > 3. Please add synonym pickle object to ../regression/test_utils.py file > 4. Can we have config data parameters generated dynamically? (e.g. schema > name) > > Let me know for any assistance. > > Thank you. > > On 26 August 2016 at 13:03, Akshay Joshi <akshay.jo...@enterprisedb.com> > wrote: > >> Thanks, patch applied. >> >> On Thu, Aug 25, 2016 at 7:58 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find updated patch. >>> >>> I have also fixed the issue in package node which was displaying create >>> menu in PG server. (separate patch attached) >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> On Thu, Aug 25, 2016 at 4:34 PM, Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> >>>> Hi Murtuza >>>> >>>> Following are my review comments: >>>> >>>> - Create "Synonym" option is visible for Postgres Servers, when >>>> right click on schema node. >>>> >>>> Fixed >>> >>>> >>>> - Unable to create Public Synonym faced "Internal Server Error". >>>> >>>> Fixed >>> >>>> >>>> - SQL help not working when click on "[i]" button. >>>> >>>> Fixed, Now it is disbaled >>> >>>> >>>> - "Public Synonyms?" switch control showing True/False when click >>>> on Synonyms collection node and it is showing Yes/No when click on >>>> synonym >>>> node under properties tab. >>>> >>>> Fixed >>> >>>> >>>> On Thu, Aug 25, 2016 at 3:08 PM, Murtuza Zabuawala < >>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> PFA updated patch with `--binary` option for .png files. >>>>> >>>>> -- >>>>> Regards, >>>>> Murtuza Zabuawala >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> On Thu, Aug 25, 2016 at 12:27 PM, Murtuza Zabuawala < >>>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> PFA patch for synonym node, this patch also includes basic unit test >>>>>> cases. >>>>>> Please review. >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> Murtuza Zabuawala >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>>> To make changes to your subscription: >>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>> >>>>> >>>> >>>> >>>> -- >>>> *Akshay Joshi* >>>> *Principal Software Engineer * >>>> >>>> >>>> >>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>> >>> >>> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > > > -- > Best, > Priyanka > > EnterpriseDB Corporation > The Enterprise PostgreSQL Company > -- Best, Priyanka EnterpriseDB Corporation The Enterprise PostgreSQL Company
