Hi while closing query tool, the following error is display on python console.
File "/Users/surinder/Documents/Projects/pgadmin4/web/pgadmin/tools/datagrid/__init__.py", line 270, in close manager.release(did=cmd_obj.did, conn_id=cmd_obj.conn_id) File "/Users/surinder/Documents/Projects/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py", line 1501, in release self.connections[my_id]._release() File "/Users/surinder/Documents/Projects/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py", line 1002, in _release if self.wasConneted: AttributeError: 'Connection' object has no attribute 'wasConneted' *Issue:* This issue is due to typo. Please find attached patch. On Tue, Sep 6, 2016 at 6:35 PM, Akshay Joshi <akshay.jo...@enterprisedb.com> wrote: > Code looks good to me. Patch applied. > > On Tue, Sep 6, 2016 at 12:05 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Fri, Sep 2, 2016 at 7:49 PM, Dave Page <dp...@pgadmin.org> wrote: >> >>> Akshay, can you review/commit this please? >>> >> >> Sure. >> >>> >>> Thanks. >>> >>> On Tue, Aug 30, 2016 at 5:05 PM, Ashesh Vashi < >>> ashesh.va...@enterprisedb.com> wrote: >>> >>>> On Tue, Aug 30, 2016 at 7:16 PM, Ashesh Vashi < >>>> ashesh.va...@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> Please find the add-on patch on top of the current change. >>>>> >>>>> Can you please take a look at it? >>>>> This mainly works on the postgres driver to make an attempt to >>>>> reconnect the server. >>>>> >>>> >>>> One more attempt with some more corner cases handling. >>>> * Handled the connection-lost, and object gone error on client side >>>> during 'refresh' operation. >>>> * Handle the reconnection more consistently (even during cursor object >>>> creation). >>>> >>>> Please take a look at it. >>>> >>>> -- >>>> >>>> Thanks & Regards, >>>> >>>> Ashesh Vashi >>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>> <http://www.enterprisedb.com/> >>>> >>>> >>>> *http://www.linkedin.com/in/asheshvashi* >>>> <http://www.linkedin.com/in/asheshvashi> >>>> >>>>> >>>>> -- >>>>> >>>>> Thanks & Regards, >>>>> >>>>> Ashesh Vashi >>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>> <http://www.enterprisedb.com> >>>>> >>>>> >>>>> *http://www.linkedin.com/in/asheshvashi* >>>>> <http://www.linkedin.com/in/asheshvashi> >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >
fix_typo_in_pyscopg2_driver.patch
Description: Binary data
-- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers