On Mon, Sep 12, 2016 at 11:13 AM, Murtuza Zabuawala <murtuza.zabuawala@ enterprisedb.com> wrote:
> Hi Surinder, > > Just a heads up, When server is not connected and listed down in browser > tree then node has attribute 'type' instead of 'server_type'. > I have fixed similar issue few days ago Ref. link > <https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commit;h=013ff1090e4b084166077a9e43196a91d7e17e24> > Yup this was a bug . Previously, *server_type* was not returned on listing down after disconnect then connect. And it has already been taken care in this commit <https://www.postgresql.org/message-id/e1bbnip-00020x...@gothos.postgresql.org> . So, the check will work fine with *server_type. * > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Sep 12, 2016 at 10:42 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> *Please find attached with following fixes:* >> >> 1) The function '*canCreateProc*' that checks if package is auth to >> create under catalog gets failed due to improper check of 'type'. Instead >> check should be like >> node_hierarchy['server'].*server_type* == "ppas" not >> node_hierarchy['server'].*type* == "ppas" >> >> 2) Also found, *package.js* was loading at schema level, due to this, >> context menu doesn't popup under catalog. Now it is load at database level. >> >> 3) In *package.js*, remove extra comma from columns array. >> >> 4) Rule create option should not available on table under catalogs. Fixed. >> >> Please review. >> >> Thanks, >> Surinder Kumar >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> >
