Thanks - committed with a minor change to remove a duplicate WHERE clause that you added to one of the queries.
On Thu, Sep 15, 2016 at 5:22 PM, Magnus Hagander <mag...@hagander.net> wrote: > There are a number of cases where queries in both pgadmin4 and pgadmin3 are > done against pg_depend but falis to constrain the query on classid. > > In particular, if for example a constraint and a sequence exists with the > same oid (which is perfectly valid, as they are in different tables), a > column will suddenly refer sequences that are completely incorrect. When we > look up sequences, we have to make sure we only match dependencies against > pg_class. > > AFAICT, the following patch catches the important ones. I could go ahead and > push it, but given that we're in RC I'd appreciate a round of review before > doing that, even though it looks fairly simple. > > I've got the same changes in a patch to pgadmin3, as these queries are > basically a copy/paste from there. But let's focus the review on the one for > pgadmin4 :) > > -- > Magnus Hagander > Me: http://www.hagander.net/ > Work: http://www.redpill-linpro.com/ > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
