Hi,
Please find the attached patch to fix the regression bug due to this (RM
1801) fix.
Issue: While creating database, gets an error while changing the tab to SQL
tab.
Thanks,
Khushboo
On Fri, Dec 9, 2016 at 5:29 PM, Dave Page <dp...@pgadmin.org> wrote:
> Thanks, patch applied.
>
> On Fri, Dec 9, 2016 at 5:32 AM, Khushboo Vashi
> <khushboo.va...@enterprisedb.com> wrote:
> > Hi,
> >
> > Please find the attached updated patch.
> >
> > Thanks,
> > Khushboo
> >
> > On Mon, Dec 5, 2016 at 11:09 PM, Dave Page <dp...@pgadmin.org> wrote:
> >>
> >> Hi
> >>
> >> On Friday, December 2, 2016, Khushboo Vashi
> >> <khushboo.va...@enterprisedb.com> wrote:
> >>>
> >>> Hi.
> >>>
> >>> Please find the attached updated patch.
> >>>
> >>> Thanks,
> >>> Khushboo
> >>>
> >>> On Fri, Nov 25, 2016 at 7:12 PM, Dave Page <dp...@pgadmin.org> wrote:
> >>>>
> >>>> Hi
> >>>>
> >>>> On Fri, Nov 25, 2016 at 12:19 PM, Khushboo Vashi
> >>>> <khushboo.va...@enterprisedb.com> wrote:
> >>>> > Hi,
> >>>> >
> >>>> > Please find the attached updated patch.
> >>>>
> >>>> Please see the attached screenshot. It's still offering to let me
> >>>> connect to a database with datallowconn=false, or create objects in
> >>>> it.
> >>>>
> >>> Fixed.
> >>>
> >>>>
> >>>> It also doesn't display the properties or dashboard for it if I click
> >>>> on it - it just silently keeps displaying the properties/dashboard for
> >>>> the previous database.
> >>>>
> >>> Fixed.
> >>
> >>
> >> I'm still seeing graphs being generated when I've selected a template
> >> database with datallowconn = true. What is it showing me? I'm seeing
> >> transactions, tuple and block I/O, which I would not expect from a
> database
> >> that noone can connect to.
> >>
> >
> > Fixed
> >
> >>
> >> Thanks.
> >>
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >>
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/web/pgadmin/browser/server_groups/servers/databases/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/__init__.py
index 0c96d6b..f138cdd 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/__init__.py
@@ -715,7 +715,8 @@ class DatabaseView(PGChildNodeView):
acls = []
SQL_acl = ''
- if data['datallowconn']:
+ if ('datallowconn' in data and data['datallowconn']) or\
+ 'datallowconn' not in data:
try:
acls = render_template(
"/".join([self.template_path, 'allowed_privs.json'])
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
