On Fri, Feb 3, 2017 at 1:59 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote:
> > > On Fri, Feb 3, 2017 at 7:02 PM, Dave Page <dave.p...@enterprisedb.com> > wrote: > >> I doubt the order matters, but feel free to change it if it bugs you :-) >> >> > I have tried to create the function with both SQL commands. > There is no bug, its just in pgAdmin4, if its not leakproof then we > mentioned 'NOT LEAKPROOF' in the SQL. > So, I am not sure, we should remove it or not. > Well we should be consistent - we either list the full set of all options, or just the non-default ones. The main thing is that we don't explicitly show options that are the default in some cases, but not in others. > > On Fri, Feb 3, 2017 at 12:54 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> I have reviewed the patch and after applying it output in pgAdmin4 >>> >>> CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 >>> geometry) >>> RETURNS boolean >>> LANGUAGE 'sql' >>> COST 100.0 >>> *IMMUTABLE NOT LEAKPROOF * >>> * PARALLEL SAFE* >>> AS $function$ >>> SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Intersects($1,$2) >>> $function$; >>> >>> but as per psql it should be >>> >>> CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 >>> geometry) >>> >>> RETURNS boolean >>> >>> LANGUAGE sql >>> >>> *IMMUTABLE PARALLEL SAFE* >>> >>> AS $function$SELECT $1 OPERATOR(public.&&) $2 AND >>> public._ST_Intersects($1,$2)$function$ >>> >>> >>> is this behaviour correct?? >>> >>> >>> >>> On Fri, Feb 3, 2017 at 5:31 PM, Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Please find the attached patch to fix RM 2089 : PARALLEL SAFE support >>>> for functions missing. >>>> >>>> Fix: Incorporated the PARALLEL SAFE support for the functions and >>>> procedures for PostgreSQL 9.6. >>>> >>>> Thanks, >>>> Khushboo >>>> >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>>> >>> >>> >>> -- >>> *Akshay Joshi* >>> *Principal Software Engineer * >>> >>> >>> >>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>> 976-788-8246 <+91%2097678%2088246>* >>> >> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> > > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake
