Thanks, applied. On Mon, Feb 6, 2017 at 6:12 AM, Murtuza Zabuawala <murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find a fix for the same, attribute length was set to False instead of > None. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Feb 6, 2017 at 11:18 AM, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com> wrote: >> >> Sure, Checking. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Sat, Feb 4, 2017 at 7:34 PM, Dave Page <dp...@pgadmin.org> wrote: >>> >>> Hi Murtuza, >>> >>> I clearly neglected to run the regression tests with this patch, and >>> unfortunately it looks like it broke them. Can you look at this ASAP >>> please? >>> >>> runTest >>> (pgadmin.browser.server_groups.servers.databases.schemas.tables.column.tests.test_column_add.ColumnAddTestCase) >>> This function will add column under table node. (Add table Node URL) >>> ... 2017-02-04 14:43:55,191: ERROR pgadmin: Failed to execute query >>> (execute_scalar) for the server #4 - DB:test_db_9e176 (Query-id: >>> 4792242): >>> Error Message:ERROR: syntax error at or near "False" >>> LINE 2: ADD COLUMN test_column_add_f0d5d char(False); >>> ^ >>> FAIL >>> >>> As far as I can see, the app works fine - it's only the test that >>> broke (probably because the application uses type name aliases (e.g. >>> character) rather than the base type name that the test is using >>> ("char"). >>> >>> Thanks. >>> >>> On Fri, Feb 3, 2017 at 1:52 PM, Dave Page <dp...@pgadmin.org> wrote: >>> > Thanks - patch applied. >>> > >>> > On Fri, Feb 3, 2017 at 11:46 AM, Murtuza Zabuawala >>> > <murtuza.zabuaw...@enterprisedb.com> wrote: >>> >> Hi, >>> >> >>> >> Please find updates patch for the same. >>> >> RM#2076 >>> >> >>> >> -- >>> >> Regards, >>> >> Murtuza Zabuawala >>> >> EnterpriseDB: http://www.enterprisedb.com >>> >> The Enterprise PostgreSQL Company >>> >> >>> >> On Wed, Feb 1, 2017 at 3:08 PM, Dave Page <dp...@pgadmin.org> wrote: >>> >>> >>> >>> Hi >>> >>> >>> >>> On Tue, Jan 31, 2017 at 5:19 AM, Murtuza Zabuawala >>> >>> <murtuza.zabuaw...@enterprisedb.com> wrote: >>> >>> > Hi Dave, >>> >>> > >>> >>> > PFA updated patch. >>> >>> >>> >>> This seems to display "timestamp(0) with[out] timezone" columns >>> >>> correctly in both the properties panel and dialog now, but the size >>> >>> is >>> >>> still ignored if I try to add a new column through the table or >>> >>> column >>> >>> dialogue. >>> >>> >>> >>> -- >>> >>> Dave Page >>> >>> Blog: http://pgsnake.blogspot.com >>> >>> Twitter: @pgsnake >>> >>> >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> >>> The Enterprise PostgreSQL Company >>> >> >>> >> >>> > >>> > >>> > >>> > -- >>> > Dave Page >>> > Blog: http://pgsnake.blogspot.com >>> > Twitter: @pgsnake >>> > >>> > EnterpriseDB UK: http://www.enterprisedb.com >>> > The Enterprise PostgreSQL Company >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >> >> >
-- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
