[Adding Akshay] On Tue, Feb 28, 2017 at 1:37 PM, Dave Page <dp...@pgadmin.org> wrote: > Thanks Murtuza. > > Akshay, can you please review/commit this by EOD tomorrow please, > making any required changes as needed? My queue is just too long at > the moment - and we need it in as soon as possible to maximise testing > time. > > Thanks. > > On Tue, Feb 28, 2017 at 10:33 AM, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com> wrote: >> Hi Dave, >> >> PFA updated patch for the same. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Mon, Feb 27, 2017 at 8:34 PM, Dave Page <dp...@pgadmin.org> wrote: >>> >>> Hi >>> >>> On Mon, Feb 27, 2017 at 10:25 AM, Murtuza Zabuawala >>> <murtuza.zabuaw...@enterprisedb.com> wrote: >>> > Hi, >>> > >>> > PFA patch to reduce the size of query result set by converting it into >>> > 2D >>> > array result set. >>> > RM#2036 >>> > RM#2038 >>> > >>> > Additionally, >>> > 1) I had to change some logic in Debugger module to handle 2D array >>> > result >>> > set from async query (changes included in patch). >>> >>> - The first test I tried had a typo in the table name: >>> >>> 2017-02-27 14:44:14,403: SQL pgadmin: Execute (async) for server #1 - >>> CONN:7535990 (Query-id: 269320): >>> select * from pg_table >>> 2017-02-27 14:44:14,405: INFO werkzeug: 127.0.0.1 - - [27/Feb/2017 >>> 14:44:14] "POST /sqleditor/query_tool/start/2431806 HTTP/1.1" 200 - >>> 2017-02-27 14:44:14,436: SQL pgadmin: Polling result for (Query-id: >>> 269320) >>> 2017-02-27 14:44:14,443: INFO werkzeug: 127.0.0.1 - - [27/Feb/2017 >>> 14:44:14] "GET /sqleditor/poll/2431806 HTTP/1.1" 500 - >>> Traceback (most recent call last): >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 2000, in __call__ >>> return self.wsgi_app(environ, start_response) >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 1991, in wsgi_app >>> response = self.make_response(self.handle_exception(e)) >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 1567, in handle_exception >>> reraise(exc_type, exc_value, tb) >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 1988, in wsgi_app >>> response = self.full_dispatch_request() >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 1641, in full_dispatch_request >>> rv = self.handle_user_exception(e) >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 1544, in handle_user_exception >>> reraise(exc_type, exc_value, tb) >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 1639, in full_dispatch_request >>> rv = self.dispatch_request() >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 1625, in dispatch_request >>> return self.view_functions[rule.endpoint](**req.view_args) >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask_login.py", >>> line 792, in decorated_view >>> return func(*args, **kwargs) >>> File >>> "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/__init__.py", >>> line 476, in poll >>> status, result = conn.poll() >>> ValueError: too many values to unpack >>> >> Fixed >>> >>> - If I copy rows from the grid, for some reason 'true' is quoted, >>> whilst false is not: >>> >>> >>> 'information_schema','sql_implementation_info','postgres',,false,false,false >>> 'information_schema','sql_parts','postgres',,false,false,false >>> 'information_schema','sql_features','postgres',,false,false,false >>> 'pem','server_version','postgres',,'true',false,'true' >>> >> Fixed >>> >>> - I get the same error as above, if I try to run "create table foo(id >>> serial)" >>> >> Fixed >>> >>> - "columns_info" should be "column_info", as "def >>> get_columns_info(self)" should be "def get_column_info(self)" >>> >> Fixed >>> >>> > 2) While testing I also found one issue where we are unable to right >>> > click >>> > on browser tree if we set Debug = False in config_local.py file, this >>> > was >>> > because of typo as path for css was changed to '/js/' to '/vendor/'. >>> > (separate patch RM#2213) >>> >>> Thanks, applied (along with the change to the About dialogue). >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >> >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company
-- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
