On Wed, Mar 1, 2017 at 10:27 PM, Dave Page <dp...@pgadmin.org> wrote:
> You're going to deal with the final review/commit right Ashesh? > Yes - I am planning to. > > On Wed, Mar 1, 2017 at 11:41 AM, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com> wrote: > > Hi, > > > > Patch looks good to me, Tested with Python3.5(manually) attached > screenshot > > & Python2.7 (using TestSuite). > > > > -- > > Regards, > > Murtuza Zabuawala > > EnterpriseDB: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > > On Tue, Feb 28, 2017 at 1:24 PM, Harshal Dhumal > > <harshal.dhu...@enterprisedb.com> wrote: > >> > >> Hi, > >> > >> Please find updated patch for encoding issue. > >> > >> Apart from encoding issue I have also fixed issue of wrong data was show > >> in query editor for string types and array string types for databases > with > >> encoding other than utf-8. > >> > >> > >> > >> -- > >> Harshal Dhumal > >> Software Engineer > >> > >> EnterpriseDB India: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > >> > >> On Fri, Feb 24, 2017 at 4:41 PM, Dave Page <dp...@pgadmin.org> wrote: > >>> > >>> Hi > >>> > >>> On Thu, Feb 23, 2017 at 10:34 AM, Harshal Dhumal > >>> <harshal.dhu...@enterprisedb.com> wrote: > >>> > Hi, > >>> > > >>> > Please find updated patch for unicode issue on python 2.7 > >>> > > >>> > I have tested with below scenarios for all nodes (except database and > >>> > Login/Group Role as these are stored in shared catalogs as for now we > >>> > are > >>> > not considering encoding issues for these two nodes) > >>> > >>> This breaks on my PG 9.4 server - I'm unable to open the Databases > >>> node. That server has both databases with Unicode names, and databases > >>> in encodings other than UTF-8. > >>> > >>> (hat-tip to George and Atira; it was their feature tests that showed > >>> up this problem :-) ) > >>> > >>> 2017-02-24 11:08:26,379: INFO werkzeug: 127.0.0.1 - - [24/Feb/2017 > >>> 11:08:26] "GET /browser/database/nodes/1/1/ HTTP/1.1" 500 - > >>> Traceback (most recent call last): > >>> File > >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/flask/app.py", > >>> line 2000, in __call__ > >>> return self.wsgi_app(environ, start_response) > >>> File > >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/flask/app.py", > >>> line 1991, in wsgi_app > >>> response = self.make_response(self.handle_exception(e)) > >>> File > >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/flask/app.py", > >>> line 1567, in handle_exception > >>> reraise(exc_type, exc_value, tb) > >>> File > >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/flask/app.py", > >>> line 1988, in wsgi_app > >>> response = self.full_dispatch_request() > >>> File > >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/flask/app.py", > >>> line 1641, in full_dispatch_request > >>> rv = self.handle_user_exception(e) > >>> File > >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/flask/app.py", > >>> line 1544, in handle_user_exception > >>> reraise(exc_type, exc_value, tb) > >>> File > >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/flask/app.py", > >>> line 1639, in full_dispatch_request > >>> rv = self.dispatch_request() > >>> File > >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/flask/app.py", > >>> line 1625, in dispatch_request > >>> return self.view_functions[rule.endpoint](**req.view_args) > >>> File > >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/flask/views.py", > >>> line 84, in view > >>> return self.dispatch_request(*args, **kwargs) > >>> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line > >>> 235, in dispatch_request > >>> return method(*args, **kwargs) > >>> File > >>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ > groups/servers/databases/__init__.py", > >>> line 151, in wrapped > >>> return f(self, *args, **kwargs) > >>> File > >>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ > groups/servers/databases/__init__.py", > >>> line 228, in nodes > >>> res = self.get_nodes(gid, sid) > >>> File > >>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ > groups/servers/databases/__init__.py", > >>> line 198, in get_nodes > >>> dbname = dbname.decode('utf-8') > >>> File > >>> "/System/Library/Frameworks/Python.framework/Versions/2.7/ > lib/python2.7/encodings/utf_8.py", > >>> line 16, in decode > >>> return codecs.utf_8_decode(input, errors, True) > >>> UnicodeEncodeError: 'ascii' codec can't encode characters in position > >>> 0-5: ordinal not in range(128) > >>> > >>> > >>> > >>> -- > >>> Dave Page > >>> Blog: http://pgsnake.blogspot.com > >>> Twitter: @pgsnake > >>> > >>> EnterpriseDB UK: http://www.enterprisedb.com > >>> The Enterprise PostgreSQL Company > >> > >> > >> > >> > >> -- > >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > >> To make changes to your subscription: > >> http://www.postgresql.org/mailpref/pgadmin-hackers > >> > > > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
