Hello Hackers,

We found out a issue using Python 3 related to importing modules that we
corrected in the patch that is now attached.

Also we would like to know the status of this.

Thanks
Joao & Sarah

On Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcal...@pivotal.io> wrote:

> Hi!
>
> We realized that this change was causing the tests to fail because the
> folder for the sqlite databases was not being created. We also updated the
> files to contain the missing headers.
>
> Thanks!
> Joao & Sarah
>
>
>
> On Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dp...@pgadmin.org> wrote:
>
>> Ashesh, can you review/commit this please? One thing I notice on a
>> quick look through is that the file headers are missing everywhere.
>> They should be present in all source files, except where they would
>> bloat the data transfer from client to server.
>>
>> On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcal...@pivotal.io>
>> wrote:
>> > Hi Hackers!
>> >
>> > It looks like our previous patch messed up some logging. Please use
>> this one
>> > instead.
>> >
>> > Thanks,
>> > Joao & Sarah
>> >
>> >
>> >
>> > On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcal...@pivotal.io>
>> wrote:
>> >>
>> >> Hi Hackers!
>> >>
>> >> Here's a patch to move to current db migration system to use Alembic.
>> >> Instructions to create new migrations are in the README.
>> >>
>> >> Thanks!
>> >> Joao & Sarah
>> >>
>> >
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

Attachment: 0001-Switch-to-Alembic-and-Flask-migration-db-migration-s.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Reply via email to