Thanks Dave.

1) String extraction no longer picks up strings in JS files. I guess
> we may need a custom extractor for babel?


Yeah, that's a good point. I didn't think about that. I'll put that in my
team's backlog coming up.

Here's a patch for the docs.


On Thu, Mar 23, 2017 at 8:37 AM, Dave Page <dp...@pgadmin.org> wrote:

> Hi Tira,
>
> I've been spending spare minutes starting to move the JS translations
> to use your new mechanism with an aim to minimising the Jinja
> rendering. Unfortunately, I found a couple of issues; can you look
> into them please?
>
> 1) String extraction no longer picks up strings in JS files. I guess
> we may need a custom extractor for babel?
>
> 2) The docs were never updated to reflect the changes, e.g.
> https://www.pgadmin.org/docs4/dev/translations.html
>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment: 0001-Update-the-docs-for-javascript-translations.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Reply via email to