Hi,
On Mon, Mar 27, 2017 at 9:57 PM, Dave Page <dp...@pgadmin.org> wrote:
> On Mon, Mar 27, 2017 at 7:49 AM, Khushboo Vashi
> <khushboo.va...@enterprisedb.com> wrote:
> > Hi Dave,
> >
> > I have fixed the issue and the patch for the same is attached, but the
> > Binary path options are not translated properly.
>
> Thanks - committed.
>
> > We register the preferences before the first request of the app. In this
> > case we don't have any language loaded, so it will take only English.
> > To fix this issue, I had explicitly added gettext for the labels and help
> > messages while opening the Preference dialogue.
> > All the labels and help messages render properly except Binary paths; as
> at
> > run time we don't get the translation of 'EDB Advanced Server Binary
> Path'.
> > We have translations like below:
> >
> > #: pgadmin/browser/server_groups/servers/types.py:59
> > msgid "{0} Binary Path"
> > msgstr "Ścieżka Binarna {0}"
> >
> > So, in this case my suggestion is to have the entire label/help messages
> > translations.
> > So, that the Preference dialogue can translate run time.
>
> I'm fine with that; however, the strings should come from the
> underlying drivers of course, as only they should have specific
> knowledge of details such as the name of the database server they
> provide access to.
>
> The string always comes from drivers as they are being registered from
there.
I have attached the patch to translate the entire string.
I took the reference of the string from the messages.po file and
translated, so someone has to validate that this is the correct translation.
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/web/pgadmin/translations/pl/LC_MESSAGES/messages.po b/web/pgadmin/translations/pl/LC_MESSAGES/messages.po
index ac20c13..f53c5fc 100644
--- a/web/pgadmin/translations/pl/LC_MESSAGES/messages.po
+++ b/web/pgadmin/translations/pl/LC_MESSAGES/messages.po
@@ -357,6 +357,14 @@ msgstr "Ścieżki"
msgid "{0} Binary Path"
msgstr "Ścieżka Binarna {0}"
+#: pgadmin/browser/server_groups/servers/types.py:56
+msgid "PostgreSQL Binary Path"
+msgstr "Ścieżka Binarna PostgreSQL"
+
+#: pgadmin/browser/server_groups/servers/types.py:56
+msgid "EDB Advanced Server Binary Path"
+msgstr "Ścieżka Binarna EDB Advanced Server"
+
#: pgadmin/browser/server_groups/servers/types.py:57
msgid "Binary paths"
msgstr "Ścieżki binarne"
@@ -367,6 +375,18 @@ msgid ""
"pg_restore etc)."
msgstr "Ścieżka zawierająca programy narzędziowe {0} (pg_dump, pg_restore itd)."
+#: pgadmin/browser/server_groups/servers/types.py:60
+msgid ""
+"Path to the directory containing the EDB Advanced Server utility programs (pg_dump, "
+"pg_restore etc)."
+msgstr "Ścieżka zawierająca programy narzędziowe EDB Advanced Server (pg_dump, pg_restore itd)."
+
+#: pgadmin/browser/server_groups/servers/types.py:60
+msgid ""
+"Path to the directory containing the PostgreSQL utility programs (pg_dump, "
+"pg_restore etc)."
+msgstr "Ścieżka zawierająca programy narzędziowe PostgreSQL (pg_dump, pg_restore itd)."
+
#: pgadmin/browser/server_groups/servers/types.py:111
#, python-format
msgid "Could not find the utility for the operation '%s'"
diff --git a/web/pgadmin/translations/zh/LC_MESSAGES/messages.po b/web/pgadmin/translations/zh/LC_MESSAGES/messages.po
index f07037e..7faed78 100644
--- a/web/pgadmin/translations/zh/LC_MESSAGES/messages.po
+++ b/web/pgadmin/translations/zh/LC_MESSAGES/messages.po
@@ -357,6 +357,14 @@ msgstr "路径"
msgid "{0} Binary Path"
msgstr "{0} 二进制文件路径"
+#: pgadmin/browser/server_groups/servers/types.py:56
+msgid "PostgreSQL Binary Path"
+msgstr "PostgreSQL 二进制文件路径"
+
+#: pgadmin/browser/server_groups/servers/types.py:56
+msgid "EDB Advanced Server Binary Path"
+msgstr "EDB Advanced Server 二进制文件路径"
+
#: pgadmin/browser/server_groups/servers/types.py:57
msgid "Binary paths"
msgstr "二进制路径"
@@ -367,6 +375,18 @@ msgid ""
"pg_restore etc)."
msgstr "包含{0} 实用程序（pg_dump，pg_restore等）的目录的路径。"
+#: pgadmin/browser/server_groups/servers/types.py:60
+msgid ""
+"Path to the directory containing the PostgreSQL utility programs (pg_dump, "
+"pg_restore etc)."
+msgstr "包含PostgreSQL 实用程序（pg_dump，pg_restore等）的目录的路径。"
+
+#: pgadmin/browser/server_groups/servers/types.py:60
+msgid ""
+"Path to the directory containing the EDB Advanced Server utility programs (pg_dump, "
+"pg_restore etc)."
+msgstr "包含EDB Advanced Server 实用程序（pg_dump，pg_restore等）的目录的路径。"
+
#: pgadmin/browser/server_groups/servers/types.py:111
#, python-format
msgid "Could not find the utility for the operation '%s'"
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
