> On 11 May 2017, at 07:11, Akshay Joshi <akshay.jo...@enterprisedb.com> wrote: > > Hi Sarah > >> On Thu, May 11, 2017 at 2:30 AM, Sarah McAlear <smcal...@pivotal.io> wrote: >> Hi Ashkay! >> >>> TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed with >>> below error: >>> .....\test_role_dependencies_sql.py\", line 41, in assertions\n >>> self.assertEqual(1, len(fetch_result))\nAssertionError: 1 != 0 >> >> >> We experienced a similar problem when we started developing this patch. We >> noticed that we were connecting to the database with the super user (the db >> owner user), which did not create the role we are expecting when a table is >> created. To ensure that this role is created, we had to create a new user >> and use it to execute all the tests. After we made this change, the tests >> passed. >> >> Can you try to create a new user and use it to execute your tests? > > I did that and it works. I have created new user 'test' with superuser > privileges and update parameter db_username="test" in test_config.json file. > But still I am unable to understand why it doesn't work with 'postgres' > (default) user?
Agreed. That suggests something fishy is going on that should be understood. >> >> Thanks, >> João & Sarah >> >>> On Wed, May 10, 2017 at 1:56 PM, Akshay Joshi >>> <akshay.jo...@enterprisedb.com> wrote: >>> >>> >>> On May 10, 2017 19:07, "Sarah McAlear" <smcal...@pivotal.io> wrote: >>> Hi Akshay! >>> >>> Does this error occur on 9.6 or 10.0? We tested it in 9.6 and all our tests >>> pass. >>> >>> On both 9.6 and 10.0. Query returned 0 rows which is compared against 1 >>> in assert statement. >>> >>> Thanks! >>> João & Sarah >>> >>>> On Wed, May 10, 2017 at 2:29 AM, Akshay Joshi >>>> <akshay.jo...@enterprisedb.com> wrote: >>>> Hi Sarah >>>> >>>>> On Tue, May 9, 2017 at 9:03 PM, Sarah McAlear <smcal...@pivotal.io> wrote: >>>>> Hi Akshay! >>>>> >>>>>> Some test file names ended with "_sql_template.py" do we need to add >>>>>> that string ? >>>>> >>>>> we added this suffix after moving the tests up a level to tables/tests to >>>>> clarify what subject they applied to. we changed the suffix to "_sql.py" >>>>> >>>>>> - Files "test_column_acl_sql_template.py" and >>>>>> "test_column_properties_sql_template.py" should be moved from >>>>>> tables->tests to tables->column->tests. As it's related to column. >>>>>> - Files "test_trigger_get_oid_sql_template.py" and >>>>>> "test_trigger_nodes_sql_template.py" should be moved from tables->tests >>>>>> to tables->triggers->tests. As its related to triggers. >>>>> these tests are related to the sql files in tables/templates/column, not >>>>> tables/column, so moving them into tables/column would be more confusing. >>>>> >>>>>> Following test cases are failing >>>>> >>>>> Thank you, fixed, see new patch. Can you confirm that TestTablesNodeSql >>>>> doesn't fail in your environment? >>>> >>>> TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed >>>> with below error: >>>> .....\test_role_dependencies_sql.py\", line 41, in assertions\n >>>> self.assertEqual(1, len(fetch_result))\nAssertionError: 1 != 0 >>>> >>>>> >>>>> Thanks, >>>>> George & Sarah >>>>> >>>> >>>> >>>> >>>> -- >>>> Akshay Joshi >>>> Principal Software Engineer >>>> >>>> >>>> >>>> Phone: +91 20-3058-9517 >>>> Mobile: +91 976-788-8246 >>> >>> >> > > > > -- > Akshay Joshi > Principal Software Engineer > > > > Phone: +91 20-3058-9517 > Mobile: +91 976-788-8246
