Hi Dave, Please find updated patch
On Thu, May 11, 2017 at 2:29 PM, Dave Page <dp...@pgadmin.org> wrote: > Ooops, managed to hit send too soon. > > ... it leads to failed updates such as: > > 2017-05-11 09:55:47,570: SQL pgadmin: Execute (void) for server #1 - > CONN:2096775 (Query-id: 4540472): > UPDATE public.defaults SET > data_default_no_nulls = 'asas' WHERE > ; > 2017-05-11 09:55:47,577: ERROR pgadmin: > Failed to execute query (execute_void) for the server #1 - CONN:2096775 > (Query-id: 4540472): > Error Message:ERROR: syntax error at or near ";" > LINE 3: ; > The new rows added is kept disabled untill grid is not refreshed. > > > On Thu, May 11, 2017 at 9:58 AM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> There seems to be couple of bugs in this; >> >> - When creating a new row with my test table, if I click in the id >> column, don't change anything, then click in another column, the ID column >> value changes from [default] to [null], making it impossible to save that >> row with the default value. In this case I would expect it to stay at >> [default] unless I explicitly entered a value. >> > Fixed. > >> - When I add a new row, but leave the id as [default], the row is saved, >> but the [default] marker changes from gray to black (but only in the id >> column. >> > I forgot to add 'grey_color' class for numeric type fields. Now added. > >> - I'm able to edit a freshly added row immediately after saving but >> before refreshing. This shouldn't be allowed if we don't know what the >> primary key value is, as it leads to failed updates such as: >> >> >> On Wed, May 10, 2017 at 9:52 AM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> Please find attached patch for RM only. >>> >>> *Changes:* >>> >>> - All formatters now handles both [null] and [default] values >>> >>> - the cell values are validated on server side as in pgAdmin3. >>> >>> - added light grey color for cells with [null] and [default] >>> placeholders. >>> >>> On Wed, May 10, 2017 at 2:12 PM, Dave Page <dp...@pgadmin.org> wrote: >>> >>>> >>>> >>>> On Wed, May 10, 2017 at 9:39 AM, Surinder Kumar < >>>> surinder.ku...@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> On Wed, May 10, 2017 at 2:06 PM, Dave Page <dp...@pgadmin.org> wrote: >>>>> >>>>>> Any chance we can get this wrapped up today Surinder? >>>>>> >>>>> I have fixed RM case, I am currently writing its feature test cases >>>>> which is taking some time. >>>>> Should I send patch for RM case only? I will try to complete test >>>>> cases by today eod. >>>>> >>>> >>>> Yes please. >>>> >>>> Thanks! >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
RM_2257_v4.patch
Description: Binary data
-- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
