Hi On Fri, May 12, 2017 at 3:20 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote:
> Hi Dave, > > Please find attached patch and review. > Thanks, committed. > > Also, I found an issue <https://redmine.postgresql.org/issues/2399> which > logged and will work on it. > Yes, I also saw that, though I found the colour was lost on paste, not save. I also found another issue - https://redmine.postgresql.org/issues/2400. Can you fix that too please? Thanks. > > On Fri, May 12, 2017 at 5:19 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> On Fri, May 12, 2017 at 5:00 PM, Dave Page <dp...@pgadmin.org> wrote: >> >>> >>> >>> On Fri, May 12, 2017 at 12:19 PM, Harshal Dhumal < >>> harshal.dhu...@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Below code snippet from above commit assumes that we have to disable >>>> last row after saving. >>>> >>>> @@ -2320,6 >>>> <https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=blob;f=web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js;h=2062aa2bb909794e5d2c339aec62d2d4e8ffbc28#l2320> >>>> +2340,10 >>>> <https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=blob;f=web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js;h=ba9dd4339b8d6287f454ddbde1826be1a2bea0f6;hb=4f9628ed436de53b1ab1a06b123755a86a8f2288#l2340> >>>> @@ define( >>>> grid.setSelectedRows([]); >>>> } >>>> >>>> + // Add last row(new row) to keep track of it >>>> + if (is_added) { >>>> + self.rows_to_disable.push(grid.getDat >>>> aLength()-1); >>>> + } >>>> >>>> However this is not the case all the time >>>> >>>> For e.g >>>> Table has some data already and If user adds new row (do not save) and >>>> then copy past few exiting rows (at this point newly added row no longer >>>> remains at last position). And after saving it disable last row which is >>>> not the newly added row. >>>> >>> >>> Hmm, good point. Can you/Surinder work up a fix for that in time for the >>> release please? >>> >> Sure Dave, I am working on it. >> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
