Ashesh is out this week. As long as new nodes are sorted with the same algorithm as existing ones, that's fine.
On Mon, May 15, 2017 at 8:48 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Harshal, > > We are using https://github.com/javve/natural-sort for sorting nodes > which is implemented by Ashesh. > > @Ashesh, > Any suggestion on this? > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, May 15, 2017 at 1:07 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi Murtuza, >> >> Currently nodes are sorted in case sensitive manner it should be case >> insensitive. >> >> >> >> See current Server group order is A, Servers, a1, a2. It should be A, >> a1, a2, Servers. >> Similarly check sorting order for server and database nodes >> >> >> -- >> *Harshal Dhumal* >> *Sr. Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Fri, May 12, 2017 at 7:08 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi Ashesh, >>> >>> Please find updated patch as discussed. >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> On Fri, May 12, 2017 at 11:37 AM, Murtuza Zabuawala < >>> murtuza.zabuaw...@enterprisedb.com> wrote: >>> >>>> Hi Ashesh, >>>> >>>> As discussed please find updated patch removing hardcoded check for >>>> server & server-group node. >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> On Fri, Apr 28, 2017 at 1:29 PM, Murtuza Zabuawala < >>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>> >>>>> Hi Ashesh, >>>>> >>>>> PFA updated patch for the issue. >>>>> >>>>> -- >>>>> Regards, >>>>> Murtuza Zabuawala >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> On Wed, Apr 26, 2017 at 10:29 AM, Ashesh Vashi < >>>>> ashesh.va...@enterprisedb.com> wrote: >>>>> >>>>>> >>>>>> On Mon, Apr 24, 2017 at 4:43 PM, Dave Page <dp...@pgadmin.org> wrote: >>>>>> >>>>>>> Ashesh, can you review/commit this please? Thanks. >>>>>>> >>>>>>> On Mon, Apr 24, 2017 at 6:17 AM, Murtuza Zabuawala < >>>>>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> PFA minor patch to fix the issue where node rename is not working >>>>>>>> properly after 7dd9efd8 >>>>>>>> <https://redmine.postgresql.org/projects/pgadmin4/repository/revisions/7dd9efd811c7845d9dc985b66f8d33497f2f4bfa> >>>>>>>> commit >>>>>>>> . >>>>>>>> RM#2355 >>>>>>>> >>>>>>> We should remove the existing node, and then insert at right place >>>>>> instead of refreshing the parent. >>>>>> Because - that will select the parent node, and not that node, and >>>>>> also - it adds overhead of refreshing the whole parent node. >>>>>> >>>>>> Please send the patch as per our discussion. >>>>>> >>>>>> -- Thanks, Ashesh >>>>>> >>>>>>> >>>>>>>> -- >>>>>>>> Regards, >>>>>>>> Murtuza Zabuawala >>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>> To make changes to your subscription: >>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>> >>>> >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
