We are working on this now. Should I open a bug or a feature in redmine to track this work publicly or just keep it in our backlog only?
On Thu, Jun 1, 2017 at 11:11 AM, Dave Page <dp...@pgadmin.org> wrote: > > > On Thu, Jun 1, 2017 at 3:15 PM, Matthew Kleiman <mklei...@pivotal.io> > wrote: > >> Hi Hackers! >> >> We noticed that there have been quite a few Redmine issues that ended up >> being related to the same function in sqleditor.js. We were wondering if >> it might be a good idea to extract this function and test it. This would >> allow us to iterate more quickly and identify potential bugs before they're >> opened. There have been a few merge conflicts already in this area and >> without tests it is difficult to resolve these with high confidence. >> >> The function in question is the callback for onSelectedRangesChanged. In >> the latest commit on master (12fa02), it's from line 696 to 773. >> >> >> >> > Sounds sensible. Do you have a proposed patch? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
