Shirley and I are in SF this week so we will be even more async that usual.
-- Rob On Mon, Jun 12, 2017 at 7:33 AM, Dave Page <dp...@pgadmin.org> wrote: > Adding Shirley... > > Hi > > On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar > <surinder.ku...@enterprisedb.com> wrote: > > Hi > > > > The current font-family applied to slick-grid is > 'Verdana,Arial,sans-serif'. > > I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif but > > the font size and spacing between text is reduced. so to match style I > used > > "Verdana". > > > > Also, as per my knowledge, the Helvetica font will work only for > Operating > > Systems where this font actually exists in system, otherwise it will pick > > Arial font. > > > > The right way to use 'Helvetica' is to download its 'ttf' and 'eot' files > > and use in CSS so that it appears same on all machines: > > https://stackoverflow.com/questions/13013616/css- > helvetica-neue-not-working > > > > But it seems it is not available for free > > https://www.myfonts.com/fonts/linotype/neue-helvetica/licensing.html > > Oh, that's not good. I assume we were relying on it being on a users > machine already. I think we need to do one of two things: > > 1) Default to a font that we know should exist everywhere. > 2) Have a fallback from Helvetica Neue to Arial or similar. > 3) Choose something completely new and free, and ship it with the app. > > I prefer 1 if possible, then 2, finally 3. > > Shirley, any thoughts? > > > > On Mon, Jun 12, 2017 at 6:16 PM, Dave Page <dp...@pgadmin.org> wrote: > >> > >> Hi > >> > >> Can you update this so that the CSS all follows the standards in the > >> WIP styleguide please? I see that the current patch is using the wrong > >> font for example. > >> > >> http://pgadmin4-styleguide.cfapps.io/ > >> > >> Thanks! > >> > >> On Mon, Jun 12, 2017 at 11:57 AM, Surinder Kumar > >> <surinder.ku...@enterprisedb.com> wrote: > >> > Hi > >> > > >> > Changes: > >> > > >> > 1) Calculate text editor position properly when the size of the grid > >> > exceeds > >> > the size of the window. > >> > > >> > 2) Assign NumberEditor to cell types('oid', 'xid', 'real'). > >> > > >> > 3) Remove inline styles from rendered editors and move its styles to > CSS > >> > file. > >> > > >> > Please find attached patch and review. > >> > > >> > Thanks > >> > Surinder > >> > > >> > > >> > -- > >> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org > ) > >> > To make changes to your subscription: > >> > http://www.postgresql.org/mailpref/pgadmin-hackers > >> > > >> > >> > >> > >> -- > >> Dave Page > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > >> > >> EnterpriseDB UK: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers >
