Thanks, applied. When you get some spare time (after the webpacking work that I believe you're doing), could you please add a feature test (or modify a suitable existing one) to ensure the various script options work as they should?
Thanks again! On Thu, Jun 15, 2017 at 11:55 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > Please find attached patch. It should work. > In previous patch I was unaware that i added untracked file to tracked. > > On Thu, Jun 15, 2017 at 4:10 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> Was this patch generated against a WIP branch? I get: >> >> (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/fix_scripts_in_que >> ry_tool.patch >> error: web/pgadmin/static/js/setup_connection.js: No such file or >> directory >> >> On Thu, Jun 15, 2017 at 6:36 AM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Hi >>> >>> PFA patch which fixes the issue Harshal reported. >>> >>> Thanks, >>> Surinder >>> >>> On Thu, Jun 15, 2017 at 3:52 AM, Harshal Dhumal < >>> harshal.dhu...@enterprisedb.com> wrote: >>> >>>> Surinder, >>>> >>>> I guess this broke the script options (Create, Delete, Select, Insert, >>>> Update) >>>> >>>> >>>> VM4124 datagrid.js:440 Uncaught TypeError: self.get_panel_title is not >>>> a function at Object.success (VM4124 datagrid.js:440) at fire ( >>>> jquery-1.11.2.js:3143) at Object.fireWith [as resolveWith] ( >>>> jquery-1.11.2.js:3255) at done (jquery-1.11.2.js:9309) at >>>> XMLHttpRequest.callback (jquery-1.11.2.js:9713) >>>> success @ VM4124 datagrid.js:440 >>>> fire @ jquery-1.11.2.js:3143 >>>> fireWith @ jquery-1.11.2.js:3255 >>>> done @ jquery-1.11.2.js:9309 >>>> callback @ jquery-1.11.2.js:9713 >>>> >>>> >>>> >>>> >>>> -- >>>> *Harshal Dhumal* >>>> *Sr. Software Engineer* >>>> >>>> EnterpriseDB India: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> On Tue, Jun 13, 2017 at 4:04 PM, Dave Page <dp...@pgadmin.org> wrote: >>>> >>>>> Use a more sensible name for Query Tool tabs. Fixes #2482 >>>>> >>>>> Branch >>>>> ------ >>>>> master >>>>> >>>>> Details >>>>> ------- >>>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif >>>>> f;h=57d866f7b70996a82a881b20248c3285ab3a6900 >>>>> Author: Surinder Kumar <surinder.ku...@enterprisedb.com> >>>>> >>>>> Modified Files >>>>> -------------- >>>>> web/pgadmin/browser/templates/browser/js/node.js | 4 +- >>>>> web/pgadmin/static/css/webcabin.overrides.css | 13 +++++ >>>>> .../datagrid/templates/datagrid/js/datagrid.js | 58 >>>>> ++++++++++++---------- >>>>> .../sqleditor/templates/sqleditor/js/sqleditor.js | 5 +- >>>>> 4 files changed, 49 insertions(+), 31 deletions(-) >>>>> >>>>> >>>>> -- >>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>>> To make changes to your subscription: >>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>> >>>> >>>> >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
