Dave, On Fri, Oct 18, 2019 at 3:24 AM Dave Page <dp...@pgadmin.org> wrote:
> > > On Thu, Oct 17, 2019 at 7:03 PM richard coleman < > rcoleman.ascen...@gmail.com> wrote: > >> Aditya, >> >> That's new. I have kept that setting in that file ever since the it was >> introduced. This is the *first* time it's been removed. >> > > Then you must not have been using one of our packages. If memory serves, > you run on Windows, in which the code to write a platform-specific > config_distro.py with every installation/upgrade on Windows was added on 16 > June 2016: > > > https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff;h=931f671756d43ea7d22d460fcb4c7a815a5aad11 > Actually I run it on Kubuntu *and* Windows 10. This instance was on Windows 10, downloaded from the page the automatic updater takes you to: https://www.pgadmin.org/download/pgadmin-4-windows/. At least the APT (.deb) file has the decency to warn you when the package manager wants to blindly wipe out a config file you've updated. 'Replace with the new one', 'Keep your existing one', 'See the changes between the two before you make up your mind'. With the default being to leave your config file alone. The Windows installer should at least do the same. >> Documentation of Master Password feature: >> https://www.pgadmin.org/docs/pgadmin4/development/master_password.html >> >> Link to Desktop deployment from that page: >> >> https://www.pgadmin.org/docs/pgadmin4/development/desktop_deployment.html#desktop-deployment >> >> Relevant section of config*.py files: >> ( >> https://www.pgadmin.org/docs/pgadmin4/development/config_py.html#config-py >> ): >> >> There are multiple configuration files that are read at startup by >> pgAdmin. These are as follows: >> >> - config.py: This is the main configuration file, and should not be >> modified. It can be used as a reference for configuration settings, that >> may be overridden in one of the following files. >> - config_distro.py: This file is read after config.py and is intended >> for packagers to change any settings that are required for their pgAdmin >> distribution. This may typically include certain paths and file locations. >> This file is optional, and may be created by packagers in the same >> directory as config.py if needed. >> - config_local.py: This file is read after config_distro.py and is >> intended for end users to change any default or packaging specific >> settings >> that they may wish to adjust to meet local preferences or standards.This >> file is optional, and may be created by users in the same directory as >> config.py if needed. >> >> Can you point out the section that states config_distro.py will be >> overwritten on upgrade (I can't seem to find it)? >> > > It doesn't - much as it doesn't say that any of the other few hundred > files we install may be updated. > None of the other hundreds of files that might be updated contain settings that the end user is supposed to make changes in. > > What it does clearly say is that the config_distro,py is for use by > *packagers* and config_local.py is for use by *end users*. > That would be just a wee more helpful if you actually *included* a *config_local.py* in that directory for users to update, or better yet, didn't require users to make changes to config files and just kept the settings in the Preferences UI, as you have done with *ALL* the others settings a user might be interested in changing. > > >> >> Can you explain *why* it just started replacing (in in the process >> removing the MASTER_PASSWORD_REQUIRED = False statement) it in the 4.14 >> upgrade, but not before? >> >> Thanks, >> >> rik. >> >> >> On Thu, Oct 17, 2019 at 12:50 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Richard, >>> >>> You need to add the setting in config_local.py. Other files will be >>> replaced except config_local.py. >>> >>> On Thu, Oct 17, 2019, 22:15 richard coleman <rcoleman.ascen...@gmail.com> >>> wrote: >>> >>>> Ugg, >>>> >>>> Just upgraded pgAdmin4 to the latest version 4.14. Even though I have >>>> had the Master Password requirement disabled for as long as it has been in >>>> existence, guess what I was greeted with upon starting pgAdmin4? If you >>>> guessed the prompt requiring me to create a Master Password, or be locked >>>> out of the UI, give yourself a prize. >>>> >>>> Seriously people, I don't want/need a Master Password. Not now, not >>>> *ever.* >>>> >>>> I've added the required incantation: >>>> >>>> MASTER_PASSWORD_REQUIRED = False >>>> >>>> >>>> *back* into the *config.distro.py <http://config.distro.py>* yet again. >>>> >>>> Can you please *stop* trying to force this on me (and anyone else who >>>> has no need for it)? >>>> >>>> Thanks, >>>> >>>> rik. >>>> >>> > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > rik.
