Le mardi 18 août 2009 à 23:23:19, Guillaume Lelarge a écrit :
> Le mardi 18 août 2009 à 20:16:26, David Schnur a écrit :
> > Almost all Windows applications remember the maximize state of their
> > windows the next time they start up.  I've noticed that this is not true
> > for pgAdmin; by default it always starts up non-maximized.  Changing the
> > shortcut's properties to force maximization works for the main window,
> > but new query windows are still non-maximized.
> > This is a minor issue, but saving the maximize state is a very
> > widely-accepted convention.  Windows users are accustomed to closing a
> > maximized window by moving the mouse to the upper-right corner of the
> > screen.  A window, i.e. a new query window, that always starts up
> > non-maximized can be irritating, because the usual gesture to close it
> > ends up closing the application behind it instead.
> >
> > Using version 1.10.0 (also present in 1.8.4) on Windows XP Pro SP3
>
> Thanks for your report. It is now logged as a todo:
> http://code.pgadmin.org/trac/ticket/45

Here is a patch to fix this. This is more a new feature than a fix, so it will 
be available in 1.11/1.12 release.

I've found also that we don't have minimize and maximize buttons for 
properties' dialogs. Should we add them?


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com
Index: pgadmin/dlg/dlgClasses.cpp
===================================================================
--- pgadmin/dlg/dlgClasses.cpp	(révision 8016)
+++ pgadmin/dlg/dlgClasses.cpp	(copie de travail)
@@ -341,6 +341,7 @@
 
 void pgFrame::RestorePosition(int defaultX, int defaultY, int defaultW, int defaultH, int minW, int minH)
 {
+    bool maximized=false;
     wxPoint pos(settings->Read(dlgName, wxPoint(defaultX, defaultY)));
     wxSize size;
     if (defaultW < 0)
@@ -354,13 +355,20 @@
     SetSize(pos.x, pos.y, size.x, size.y);
     if (posDefault)
         CenterOnParent();
+
+    settings->Read(dlgName+wxT("/Maximized"), &maximized, wxEmptyString);
+    if (maximized)
+        Maximize();
 }
 
 
 void pgFrame::SavePosition()
 {
 	if (!IsIconized())
+    {
 	    settings->Write(dlgName, GetSize(), GetPosition());
+        settings->Write(dlgName+wxT("/Maximized"), IsMaximized());
+    }
 }
 
 
-- 
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support

Reply via email to