On Thu, Sep 3, 2009 at 12:57 PM, Magnus Hagander<mag...@hagander.net> wrote:
> Good question. In general we shouldn't change the default behavior in > a backpatch, but I think the use-case for the current behavior is > pretty limited. It's not being back-patched. That code has been there for years, with only one complaint that I'm aware of. The complaint is a valid one though, which is why I think we should add the option for 1.12. > AIUI, nothing at all changes for single-statement queries, right? It > would only affect those that explicitly open a transaction. In which > case I think it's a reasonable default to behave the same way as psql, > which means change the default for pgadmin. > > Specifically on the patch I don't like an option named "disabled auto > rollback". Negations in options suck. It shuold be "Enable auto > rollback", and then whatever the default is can be argued. I'd also > find it very useful if this was available as a checkbox on the query > menu, not just in the options dialog. Thoughts? Which would do what - override the default for that window only, or control the default as well? I prefer the former, but some of the other options are stored for all future query windows, so there may be some inconsistency there. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-support
