Sure
On Mon, Feb 10, 2014 at 8:00 PM, Dave Page <dp...@pgadmin.org> wrote: > Ashesh; can you review this please? > > Thanks. > > > On Fri, Feb 7, 2014 at 9:17 AM, Dinesh Kumar < > dinesh.ku...@enterprisedb.com> wrote: > >> Hi Dave/Team, >> >> I would like to take the owner ship of this patch from now onwards. >> >> Sorry for my previous test case result, which is an improper one from my >> side. I believe, i need to configure the same slony version on PG 9.2 as >> well. It seems an expected behaviour if the slony version is not match. >> >> And also i have fixed one small version bug as below. >> >> BUG Details >> ------------------ >> After configuring the slony on PG 9.2 server follow the below steps. >> >> 1. Launch pgadmin III >> 2. Add New server and Right Click on Slony cluster node >> 3. Click on Restart node >> 4. Error occurred regarding procpid does not exist. (Image is attached) >> >> I have fixed this trivial bug on top of Neel's patch, and sending single >> patch for these two issues. >> >> Kindly let me know, if i miss anything here. >> >> Thanks in advance. >> >> Regards, >> Dinesh >> >> -- >> *Dinesh Kumar* >> Software Engineer >> >> Ph: +918087463317 >> Skype ID: dinesh.kumar432 >> www.enterprisedb.co >> <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> >> >> *Follow us on Twitter* >> @EnterpriseDB >> >> Visit EnterpriseDB for tutorials, webinars, >> whitepapers<http://www.enterprisedb.com/resources-community> and >> more <http://www.enterprisedb.com/resources-community> >> >> >> On Tue, Dec 10, 2013 at 2:49 AM, Dinesh Kumar < >> dinesh.ku...@enterprisedb.com> wrote: >> >>> Hi Neel, >>> >>> On Mon, Nov 11, 2013 at 6:46 PM, Neel Patel <neel.pa...@enterprisedb.com >>> > wrote: >>> >>>> Hi Ashesh, >>>> >>>> Please find the updated patch with below fix. >>>> >>>> -- Fix for slony version 1.2.23 with PG 9.0 >>>> -- Picking the correct version of slony1_base.xxx.sql >>>> -- Fix the error "no schema has been selected to create in". It gives >>>> error after deleting the slony cluster and again create the new slony >>>> cluster. >>>> -- Fix for function storeNode() API which is accepting three arguments >>>> in slony version 1.1 and 1.2 and two arguments in >>>> slony version 2.0 and above. >>>> >>>> Please let me know for any comments. >>>> >>> >>> I have tested this patch, and seems working fine. I have found one small >>> issue when i try to create a new slony cluster with PG 9.2. When i am >>> trying to create a new cluster in PG 9.2 by setting the slony-path of PG >>> 9.3, then it' showing the >>> "ERROR: could not access file "$libdir/slony1_funcs.2.2.0": No such >>> file or directory". >>> >>> Could you look into this as well. >>> >>> Thanks, >>> Dinesh >>> >>> >>>> >>>> Thanks, >>>> Neel Patel >>>> >>>> >>>> On Thu, Oct 31, 2013 at 9:41 AM, Neel Patel < >>>> neel.pa...@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Thanks Ashesh. >>>>> >>>>> I will check and let you know. >>>>> >>>>> Thanks, >>>>> Neel Patel >>>>> >>>>> >>>>> On Wed, Oct 30, 2013 at 5:19 PM, Ashesh Vashi < >>>>> ashesh.va...@enterprisedb.com> wrote: >>>>> >>>>>> Hi Neel, >>>>>> >>>>>> I test the patch with following slony-I versions: >>>>>> 1.2.27 (not working with PG 9.0) >>>>>> 2.0.x (not picking correct slony1_base.xxx.sql - as per comment, >>>>>> it should pick slony1_base.v84.sql with PG 8.4 and above, but picking >>>>>> slony1_base.v83.sql) >>>>>> >>>>>> I have not tested further. >>>>>> Can you please take a look at it? >>>>>> >>>>>> >>>>>> >>>>>> On Tue, Oct 29, 2013 at 3:38 PM, Dave Page < >>>>>> dave.p...@enterprisedb.com> wrote: >>>>>> >>>>>>> Ashesh, can you look at this one as well please? Thanks. >>>>>>> >>>>>>> On Tue, Oct 22, 2013 at 8:34 AM, Neel Patel < >>>>>>> neel.pa...@enterprisedb.com> wrote: >>>>>>> > Hi Dave, >>>>>>> > >>>>>>> > We have fixed the below two issues to support in Slony version >>>>>>> 2.2.0 with PG >>>>>>> > 9.3 in pgAdmin. >>>>>>> > >>>>>>> > Issue 1:- >>>>>>> > >>>>>>> > Bug to reproduce:- >>>>>>> > >>>>>>> > - Install PG 9.3 and slony 2.2.0 >>>>>>> > - Right click on database and click on option "New slony-I >>>>>>> cluster..." >>>>>>> > - In the dialog we are able to see the error in status bar saying >>>>>>> "Slony-I >>>>>>> > creation scripts not available; only joining possible" >>>>>>> > >>>>>>> > Solution :- >>>>>>> > >>>>>>> > As per the above conversation in new version of slony 2.2.0 >>>>>>> installation >>>>>>> > name of the sql files got changed so it is not able to find the >>>>>>> current >>>>>>> > slony version. >>>>>>> > >>>>>>> > >>>>>>> > Issue 2:- >>>>>>> > >>>>>>> > "storenode" API contains three argument in slony version 1.1 and >>>>>>> 1.2 but in >>>>>>> > slony version 2.0 onwards it contains only two arguments so that >>>>>>> issue also >>>>>>> > fixed. >>>>>>> > >>>>>>> > >>>>>>> > As per our knowledge we have tested this patch in slony 2.2.0 with >>>>>>> PG 9.3. >>>>>>> > >>>>>>> > Can anyone please test this patch and let us know if any bugs. >>>>>>> > >>>>>>> > >>>>>>> > Thanks, >>>>>>> > Neel Patel >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > On Fri, Oct 11, 2013 at 5:17 PM, Neel Patel < >>>>>>> neel.pa...@enterprisedb.com> >>>>>>> > wrote: >>>>>>> >> >>>>>>> >> Hi Sven, >>>>>>> >> >>>>>>> >> No idea regarding the next release. >>>>>>> >> >>>>>>> >> Thanks, >>>>>>> >> Neel Patel >>>>>>> >> >>>>>>> >> >>>>>>> >> On Fri, Oct 11, 2013 at 11:46 AM, Sven Meirsman < >>>>>>> sven.meirs...@gmail.com> >>>>>>> >> wrote: >>>>>>> >>> >>>>>>> >>> Hi, >>>>>>> >>> >>>>>>> >>> Thanks for the feedback. I'm looking forward to this update. Any >>>>>>> idea on >>>>>>> >>> when it will be released? >>>>>>> >>> >>>>>>> >>> regards, >>>>>>> >>> Sven >>>>>>> >>> >>>>>>> >>> >>>>>>> >>> 2013/10/11 Neel Patel <neel.pa...@enterprisedb.com> >>>>>>> >>>> >>>>>>> >>>> Hi Sven, >>>>>>> >>>> >>>>>>> >>>> Sorry for the late replay, we have checked and it is a bug in >>>>>>> pgAdmin >>>>>>> >>>> because the name of the sql files got changed in new slony >>>>>>> version ( v2.2.0 >>>>>>> >>>> ) which is used by the pgAdmin. >>>>>>> >>>> >>>>>>> >>>> Issue :- >>>>>>> >>>> >>>>>>> >>>> When we install the slony ( version less than 2.2.0 ) then it >>>>>>> will >>>>>>> >>>> install below sql files in C:\Program >>>>>>> Files\PostgreSQL\9.3\share folder. >>>>>>> >>>> >>>>>>> >>>> slony1_base.sql >>>>>>> >>>> slony1_base.v83.sql >>>>>>> >>>> slony1_base.v84.sql >>>>>>> >>>> slony1_funcs.sql >>>>>>> >>>> slony1_funcs.v83.sql >>>>>>> >>>> slony1_funcs.v84.sql >>>>>>> >>>> >>>>>>> >>>> Now in New version of slony 2.2.0 onwards the name of the above >>>>>>> sql >>>>>>> >>>> files got changed as below. >>>>>>> >>>> >>>>>>> >>>> slony1_base.2.2.0.sql >>>>>>> >>>> slony1_base.v83.2.2.0.sql >>>>>>> >>>> slony1_base.v84.2.2.0.sql >>>>>>> >>>> slony1_funcs.2.2.0.sql >>>>>>> >>>> slony1_funcs.v83.2.2.0.sql >>>>>>> >>>> slony1_funcs.v84.2.2.0.sql >>>>>>> >>>> >>>>>>> >>>> As we are using above sql files names in pgAdmin to create the >>>>>>> new slony >>>>>>> >>>> clusters so we need to change in pgAdmin also. >>>>>>> >>>> >>>>>>> >>>> We are working on this issue and submit the patch once its done. >>>>>>> >>>> >>>>>>> >>>> Thanks, >>>>>>> >>>> Neel Patel >>>>>>> >>>> >>>>>>> >>>> >>>>>>> >>>> >>>>>>> >>>> On Mon, Sep 30, 2013 at 2:05 AM, Guillaume Lelarge >>>>>>> >>>> <guilla...@lelarge.info> wrote: >>>>>>> >>>>> >>>>>>> >>>>> On Sun, 2013-09-29 at 22:29 +0200, Sven Meirsman wrote: >>>>>>> >>>>> > Sorry, My mistake. >>>>>>> >>>>> > >>>>>>> >>>>> > 'Binary Paths' is the section you choose at the left of the >>>>>>> screen. >>>>>>> >>>>> > It >>>>>>> >>>>> > contains several paths, one 'PG Bin Path' is directing to my >>>>>>> postgres >>>>>>> >>>>> > BIN >>>>>>> >>>>> > folder like you suggest. It is the Slony-I path that >>>>>>> contains the >>>>>>> >>>>> > path to >>>>>>> >>>>> > the postgres SHARE folder where the slony scripts reside. >>>>>>> >>>>> > >>>>>>> >>>>> >>>>>>> >>>>> Oh OK, you're right. >>>>>>> >>>>> >>>>>>> >>>>> On the Slony issue, I see that Dave commited a patch from Neel >>>>>>> Patel >>>>>>> >>>>> last thursday. This patch commit log is: "Ensure DDLScript >>>>>>> will work >>>>>>> >>>>> with Slony 2.2+ which has a new SQL level API.". So I guess >>>>>>> this is >>>>>>> >>>>> what >>>>>>> >>>>> you're looking for. This will be in the next minor release >>>>>>> (1.18.1), >>>>>>> >>>>> which should be available on thursday 10th october. >>>>>>> >>>>> >>>>>>> >>>>> >>>>>>> >>>>> -- >>>>>>> >>>>> Guillaume >>>>>>> >>>>> http://blog.guillaume.lelarge.info >>>>>>> >>>>> http://www.dalibo.com >>>>>>> >>>>> >>>>>>> >>>>> >>>>>>> >>>>> >>>>>>> >>>>> -- >>>>>>> >>>>> Sent via pgadmin-support mailing list ( >>>>>>> pgadmin-support@postgresql.org) >>>>>>> >>>>> To make changes to your subscription: >>>>>>> >>>>> http://www.postgresql.org/mailpref/pgadmin-support >>>>>>> >>>> >>>>>>> >>>> >>>>>>> >>> >>>>>>> >> >>>>>>> > >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Chief Architect, Tools & Installers >>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> -- >>>>>> >>>>>> Thanks & Regards, >>>>>> >>>>>> Ashesh Vashi >>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL >>>>>> Company<http://www.enterprisedb.com> >>>>>> >>>>>> >>>>>> >>>>>> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi> >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-support >>>> >>>> >>> >> > > > -- > Dave Page > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
