Hi Sanket, Quick review suggests that, you're not following the consistent name convention in new functions as per pgAdmin3 coding standard. I also observed a white-space warning, while apply the patch.
Please resend the patch after resolving these issues. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Tue, Nov 11, 2014 at 5:25 PM, Sanket Mehta <sanket.me...@enterprisedb.com > wrote: > Hi, > > Issue was occurring as mentioned below: > > While creating the new table using table wizard, when any variables or > security labels are specified for certain column then in *dlgTable* > class, it was not fetching those variable or security labels from *dlgColumn > *class. So those were not visible on *sql tab* of new table wizard. > > I have resolved that issue and created the patch for the same. > Patch is attached with this mail. Please review it and if it looks good, > please commit the code. > > > > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Tue, Nov 4, 2014 at 1:16 PM, Sanket Mehta < > sanket.me...@enterprisedb.com> wrote: > >> Sure Ashesh, >> >> I will check and get back. >> >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> >> On Tue, Nov 4, 2014 at 1:03 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Sanket, >>> >>> Can you take a look at it? >>> >>> -- >>> Thanks, >>> >>> Ashesh Vashi >>> >>> On 4 Nov 2014 12:54, "liuyuanyuan" <liuyuanyuang...@gmail.com> wrote: >>> > >>> > >>> > >>> > Hi , hackers! >>> > >>> > Currently I test some part of pgadmin GUI, and I found some potential >>> invalid input field of New Column GUI, >>> > >>> > Like Variables and Security Labels. >>> Could you please have a look on this issue? >>> > >>> > >>> > >>> > For example: >>> > >>> > OS: WIN7 64bit >>> > >>> > PostgreSQL 9.3 >>> > >>> > pgAdmin III:Version 1.18.1 >>> > >>> > I use GUI of pgadmin to create table, and add column to this table >>> (just as follow ). When I add a new column, >>> > >>> > I can add Variables (or Security Label )to this column, but finally in >>> the tab SQL of New Table Interface I find nothing >>> > >>> > of the Variables (or Security Label ) I’ve add. It seems that the >>> Variables (or Security Label ) does not work. >>> > >>> > >>> > >>> > Best Wishes! >>> > >>> > >>> > >>> > Yours >>> > >>> > Jasmine Liu >>> > >>> > >>> >>> >> >
