On Thu, Jul 16, 2015 at 1:44 PM, Sanket Mehta <sanket.me...@enterprisedb.com> wrote: > Hi Dave, > > > On Thu, Jul 16, 2015 at 5:56 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi >> >> On Thu, Jul 16, 2015 at 8:19 AM, Sanket Mehta >> <sanket.me...@enterprisedb.com> wrote: >> > Hi Dave, >> > >> > I have created a new patch with changes you have suggested. >> > Please find it attached with this mail. >> > >> > Please do review it. >> >> Doesn't the following break the schema version check in pgAgent.cpp? >> >> >> ADD_DEFINITIONS(-DPGAGENT_VERSION_MAJOR=${CPACK_PACKAGE_VERSION_MAJOR}) >> +ADD_DEFINITIONS(-DPGAGENT_VERSION="${VERSION}") > > > No Dave it does not breaking the schema version check in pgAgent.cpp. > I have tested it.
Oh, sorry - misread the diff. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-support