-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 20/04/2011 16:59, Jehan-Guillaume (ioguix) de Rorthais wrote: > On 20/04/2011 13:04, Jehan-Guillaume (ioguix) de Rorthais wrote: >> PFA a patch that split reporting functions and cleanup a bit this piece >> of code. HEre is the changelog: > >> * split all functions so we have getters usable from pcp commands >> * factorize some pieces of code (send_row_description and >> send_complete_and_ready) >> * send a proper CommandComplete message, including the row number >> * doesn't rely on sizeof(type) to set postgresql message length, but >> directly on the protocol definition. > >> Thank you for comments and review ! > > PFA a patch to apply on top of my previous patch > "split_reporting_functions-1.patch". > > This patch adds the pcp command "pool status" and its related system > command "pcp_pool_status". > > Comments: > * I tried to add pcp_pool_status to the pcp Makefile, but I couldn't > make it build. I looks like I have to rebuild the pcp/Makefile.in, but I > don't know how to do. Any help ? > * I picked 'B' in the pcp protocol for this ccommand. I should admit I > don't understand how this lietters are chosen. Feel free to change that > * feel free to change the output of the command pcp_pool_status
PFA a second version of the patch "pcp_pool_status-2.patch" Changelog: move the POOL_REPORT* types to "pool_type.h". * it's a better place to them * it was required to have pool.h in the installation include dir when building pgpool_adm. Apply this patch on top of "split_reporting_functions-1.patch". > > Comments ? review ? > > Next step will be to add this to the contrib module "pgpool_adm" as soon > as this patch is OK. - -- Jehan-Guillaume (ioguix) de Rorthais DBA http://www.dalibo.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk2vIckACgkQXu9L1HbaT6JfBACfawxxFsVYpMMAXrtIl4BPChQ6 aAkAoK/I1+gP0dtR8Cc9GW+Ugge2zaKl =wKfb -----END PGP SIGNATURE-----
pcp_pool_status-2.patch.gz
Description: application/gzip
_______________________________________________ Pgpool-hackers mailing list [email protected] http://pgfoundry.org/mailman/listinfo/pgpool-hackers
