On Fri, 2011-06-24 at 10:56 +0200, Jehan-Guillaume (ioguix) de Rorthais wrote: > On 23/06/2011 08:42, Tatsuo Ishii wrote: > > Hi, > > > > I have committed pg_adm functions written by Jehan-Guillaume (ioguix) > > de Rorthais under pgpool_adm directory. Thank you for the > > contribution! > > Thank you Tatsuo. > > I am currently working on refactoring pcp_proc_info as discussed some > days ago. > I already done most of the work, but I have to patch the standalone > commands now (pcp_proc_count and pcp_proc_info). > > Moreover, what about having pcp_proc_info and "show pool_processes" > returning the same output ?? >
Yeah, that would be interesting. I would prefer to have a switch on the command line to see all processes (-a for example). > > Here are some issues I notice so far: > > > > - Compiler warning: > > > > $ LANG=C make USE_PGXS=1 > > gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith > > -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv > > -fpic -I/usr/local/pgsql/include -I. -I. -I/usr/local/pgsql/include/server > > -I/usr/local/pgsql/include/internal -D_GNU_SOURCE -c -o pgpool_adm.o > > pgpool_adm.c > > pgpool_adm.c: In function 'check_pcp_conninfo_props': > > pgpool_adm.c:54: warning: comparison is always false due to limited range > > of data type > > gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith > > -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv > > -fpic -shared -o pgpool_adm.so pgpool_adm.o -L/usr/local/pgsql/lib > > -Wl,--as-needed -Wl,-rpath,'/usr/local/pgsql/lib',--enable-new-dtags -lpcp > > Thank you for this report. > > > - No documentations > > I'll write it as soon as I added all functions. We still lack a bunch of > them. > > > -- > > Tatsuo Ishii > > SRA OSS, Inc. Japan > > English: http://www.sraoss.co.jp/index_en.php > > Japanese: http://www.sraoss.co.jp > > _______________________________________________ > Pgpool-hackers mailing list > Pgpool-hackers@pgfoundry.org > http://pgfoundry.org/mailman/listinfo/pgpool-hackers > -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com _______________________________________________ Pgpool-hackers mailing list Pgpool-hackers@pgfoundry.org http://pgfoundry.org/mailman/listinfo/pgpool-hackers
