On 6 December 2017 at 20:59, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Wed, Dec 6, 2017 at 5:01 AM, Amit Khandekar <amitdkhan...@gmail.com> >> wrote: >>> In attached revised patch, just added some comments in the changes that you >>> did. > >> Committed, thanks. > > While this patch (looks like it) fixes the logic error, it does nothing > for the problem that the committed test cases don't actually exercise > any of this code on most machines -- certainly not whichever one is > producing the code coverage report: > https://coverage.postgresql.org/src/backend/executor/nodeAppend.c.gcov.html > > Can we do something with Andres' suggestion of running these test cases > under parallel_leader_participation = off? > > regards, tom lane
Yes, I am planning to send a patch that makes all those Parallel-Append test cases run once with parallel_leader_participation "on" and then run again with the guc "off" . Thanks. -- Thanks, -Amit Khandekar EnterpriseDB Corporation The Postgres Database Company
