Add an assertion that we don't pass NULL to snprintf("%s"). Per commit e748e902d, we appear to have little or no coverage in the buildfarm of machines that will dump core when asked to printf a null string pointer. Let's try to improve that situation by adding an assertion that will make src/port/snprintf.c behave that way. Since it's just an assertion, it won't break anything in production builds, but it will help developers find this type of oversight.
Note that while our buildfarm coverage of machines that use that snprintf implementation is pretty thin on the Unix side (apparently amounting only to gaur/pademelon), all of the MSVC critters use it. Discussion: https://postgr.es/m/156b989dbc6fe7c4d3223cf51da61...@postgrespro.ru Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/0c62356cc8777961221a643fa77f62e1c7361085 Modified Files -------------- src/port/snprintf.c | 2 ++ 1 file changed, 2 insertions(+)