On Wed, Apr 4, 2018 at 10:40 PM, Andres Freund <and...@anarazel.de> wrote:
> Hi, > > On 2018-04-03 08:32:45 -0700, Andres Freund wrote: > > Hi, > > > > On 2018-04-03 09:24:12 +0000, Simon Riggs wrote: > > > New files for MERGE > > > src/backend/executor/nodeMerge.c | 575 +++++++ > > > src/backend/parser/parse_merge.c | 660 ++++++++ > > > src/include/executor/nodeMerge.h | 22 + > > > src/include/parser/parse_merge.h | 19 + > > > > Getting a bit grumpy here. So you pushed this, without responding in > > any way to the objections I made in > > http://archives.postgresql.org/message-id/20180403021800. > b5nsgiclzanobiup%40alap3.anarazel.de > > and did it in a manner that doesn't even compile? > > This needs at the very least a response to the issues pointed out in the > referenced email that you chose to ignore without any sort of comment. > > Apologies from my end. Simon checked with me regarding your referenced email. I was in the middle of responding to it (with a add-on patch to take care of your review comments), but got side tracked by some high priority customer escalation. I shall respond soon. Thanks, Pavan -- Pavan Deolasee http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
