Fix incorrect logic for choosing the next Parallel Append subplan

In 499be013de support for pruning unneeded Append subnodes was added.
The logic in that commit was not correctly checking if the next subplan
was in fact a valid subplan. This could cause parallel workers processes
to be given a subplan to work on which didn't require any work.

Per code review following an otherwise unexplained regression failure in
buildfarm member Pademelon.  (We haven't been able to reproduce the
failure, so this is a bit of a blind fix in terms of whether it'll
actually fix it; but it is a clear bug nonetheless).

In passing, also add a comment to explain what first_partial_plan means.

Author: David Rowley
Discussion: 
https://postgr.es/m/CAKJS1f_E5r05hHUVG3UmCQJ49DGKKHtN=shybd44ldzbn+c...@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/468abb8f7a69c68341b6fc2797166d1079acb1b1

Modified Files
--------------
src/backend/executor/nodeAppend.c | 50 +++++++++++++++++++++++++++++----------
src/include/nodes/plannodes.h     |  5 ++++
2 files changed, 43 insertions(+), 12 deletions(-)

Reply via email to