Fix potentially-unportable code in contrib/adminpack. Spelling access(2)'s second argument as "2" is just horrid. POSIX makes no promises as to the numeric values of W_OK and related macros. Even if it accidentally works as intended on every supported platform, it's still unreadable and inconsistent with adjacent code.
In passing, don't spell "NULL" as "0" either. Yes, that's legal C; no, it's not project style. Back-patch, just in case the unportability is real and not theoretical. (Most likely, even if a platform had different bit assignments for access()'s modes, there'd not be an observable behavior difference here; but I'm being paranoid today.) Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/16d3dbe2f30ab40a78873029d33aeed2765fa0d0 Modified Files -------------- contrib/adminpack/adminpack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)