On 24 April 2018 at 03:12, Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > Remove useless default clause in switch > > The switch covers all values of the enum driver variable, so having a > default: clause is useless, even if it's only to do Assert(false).
Just for my own understanding: I always thought that when all options were covered that we generally kept a default just in case someone added another enum and forgot to update the code. I know generally those are with elog ERRORs but both would be designed to alert a programmer, just at different times. There are other examples in that file with the switch (part_scheme->strategy), these are not using enums. I'd have to assume that these must be different because of that. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
