Fix mishandling of sortgroupref labels while splitting SRF targetlists. split_pathtarget_at_srfs() neglected to worry about sortgroupref labels in the intermediate PathTargets it constructs. I think we'd supposed that their labeling didn't matter, but it does at least for the case that GroupAggregate/GatherMerge nodes appear immediately under the ProjectSet step(s). This results in "ERROR: ORDER/GROUP BY expression not found in targetlist" during create_plan(), as reported by Rajkumar Raghuwanshi.
To fix, make this logic track the sortgroupref labeling of expressions, not just their contents. This also restores the pre-v10 behavior that separate GROUP BY expressions will be kept distinct even if they are textually equal(). Discussion: https://postgr.es/m/CAKcux6=1_ye9kx8ylbpmjs_xe72ppc6vni5q2aohowmacwj...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/07e5a213524853c06684155d4af5a0291d95d25a Modified Files -------------- src/backend/optimizer/util/tlist.c | 146 +++++++++++++++++++++++--- src/test/regress/expected/select_parallel.out | 62 +++++++++++ src/test/regress/sql/select_parallel.sql | 7 ++ 3 files changed, 198 insertions(+), 17 deletions(-)
