On Wed, Apr 10, 2019 at 3:10 PM Fabien COELHO <coe...@cri.ensmp.fr> wrote: > > > Hello Masahiko-san, > > > This change leads a compiler warning on my machine: > > > > pgbench.c: In function ‘readCommandResponse’: > > pgbench.c:2730: warning: ISO C90 forbids mixed declarations and code > > <https://www.postgresql.org/docs/devel/source-conventions.html> says: > > "Code in PostgreSQL should only rely on language features available in the > C99 standard" > > So it should be all right wrt to warnings. > > However the pg style in the same page says that intermingling decl & code > is not permitted, so the proposed patch should be applied.
Thank you! I didn't know the detail of that PostgreSQL supports C99 standard but I hope the warning will be fixed and coming patches will still obey that rule. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
