Remove pg_rewind's private logging.h/logging.c files. The existence of these files became rather confusing with the introduction of a widely-known logging.h header in commit cc8d41511. (Indeed, there's already some duplicative #includes here, perhaps betraying such confusion.) The only thing left in them, after that commit, is a progress-reporting function that's neither general-purpose nor tied in any way to other logging infrastructure. Hence, let's just move that function to pg_rewind.c, and get rid of the separate files.
Discussion: https://postgr.es/m/[email protected] Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/53ddefbaf8a0493d2c1fa0b18bfaba72da556985 Modified Files -------------- src/bin/pg_rewind/Makefile | 2 +- src/bin/pg_rewind/copy_fetch.c | 1 - src/bin/pg_rewind/file_ops.c | 1 - src/bin/pg_rewind/filemap.c | 2 -- src/bin/pg_rewind/libpq_fetch.c | 2 -- src/bin/pg_rewind/logging.c | 79 ----------------------------------------- src/bin/pg_rewind/logging.h | 25 ------------- src/bin/pg_rewind/nls.mk | 2 +- src/bin/pg_rewind/parsexlog.c | 1 - src/bin/pg_rewind/pg_rewind.c | 62 ++++++++++++++++++++++++++++++-- src/bin/pg_rewind/pg_rewind.h | 12 +++++++ src/bin/pg_rewind/timeline.c | 1 - 12 files changed, 74 insertions(+), 116 deletions(-)
