When performing a base backup, check for read errors. The old code didn't differentiate between a read error and a concurrent truncation. fread reports both of these by returning 0; you have to use feof() or ferror() to distinguish between them, which this code did not do.
It might be a better idea to use read() rather than fread() here, so that we can display a less-generic error message, but I'm not sure that would qualify as a back-patchable bug fix, so just do this much for now. Jeevan Chalke, reviewed by Jeevan Ladhe and by me. Discussion: http://postgr.es/m/ca+tgmobg4ywmzl5oqq2a8ykp8x2p3p1lommcgqps7aekt9+...@mail.gmail.com Branch ------ REL9_4_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fbe897134801504a3f1240d61cb78a69bc0850a5 Modified Files -------------- src/backend/replication/basebackup.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
